Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only do ThreadPool worker tracking when the thread pool event source is enabled #47871

Closed
jkoritzinsky opened this issue Feb 4, 2021 · 2 comments · Fixed by #56862
Closed

Only do ThreadPool worker tracking when the thread pool event source is enabled #47871

jkoritzinsky opened this issue Feb 4, 2021 · 2 comments · Fixed by #56862
Assignees
@kouvel
Labels
area-System.Threading size-reduction Issues impacting final app size primary for size sensitive workloads
Milestone
6.0.0

Comments

@jkoritzinsky
Copy link
Member

Per #47592 (comment), we should only do worker tracking when the thread pool event source and event sources in general are enabled.

cc: @marek-safar @eerhardt
@jkoritzinsky jkoritzinsky added area-System.Threading linkable-framework Issues associated with delivering a linker friendly framework labels Feb 4, 2021
@ghost
Copy link

ghost commented Feb 4, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

Per #47592 (comment), we should only do worker tracking when the thread pool event source and event sources in general are enabled.

cc: @marek-safar @eerhardt

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Threading, linkable-framework
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 4, 2021
@jkoritzinsky jkoritzinsky mentioned this issue Feb 4, 2021
Merged
@jkoritzinsky jkoritzinsky added size-reduction Issues impacting final app size primary for size sensitive workloads and removed linkable-framework Issues associated with delivering a linker friendly framework labels Feb 4, 2021
@ghost
Copy link

ghost commented Feb 4, 2021

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @tannergooding
See info in area-owners.md if you want to be subscribed.

Issue Details

Per #47592 (comment), we should only do worker tracking when the thread pool event source and event sources in general are enabled.

cc: @marek-safar @eerhardt

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Threading, size-reduction, untriaged
Milestone: -

@eerhardt eerhardt added this to the 6.0.0 milestone May 11, 2021
@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2021
kouvel added a commit to kouvel/runtime that referenced this issue Aug 4, 2021
@kouvel
Check EventSource.IsSupported in code paths specific to thread pool…
affe694 
… worker tracking

Fixes dotnet#47871
@kouvel kouvel mentioned this issue Aug 4, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2021
@kouvel kouvel assigned kouvel and unassigned joperezr Aug 4, 2021
kouvel added a commit that referenced this issue Aug 10, 2021
@kouvel
Check EventSource.IsSupported in code paths specific to thread pool…
78d5d1c 
… worker tracking (#56862)

Check `EventSource.IsSupported` in code paths specific to thread pool worker tracking

Fixes #47871
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kouvel kouvel

Labels
area-System.Threading size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Check EventSource.IsSupported in code paths specific to thread pool worker tracking kouvel/runtime
5 participants
@jkoritzinsky @eerhardt @kouvel @joperezr @mangod9