Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] SendReceive_VaryingLengthBuffers_Success failing in CI #53957

Closed
ViktorHofer opened this issue Jun 9, 2021 · 20 comments · Fixed by #54453 or #72843
Closed

[wasm] SendReceive_VaryingLengthBuffers_Success failing in CI #53957

ViktorHofer opened this issue Jun 9, 2021 · 20 comments · Fixed by #54453 or #72843
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Net disabled-test The test is disabled in source code against the issue
Milestone

Comments

@ViktorHofer
Copy link
Member

[20:06:15] info: Discovering: System.Net.WebSockets.Client.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:06:15] info: Discovered:  System.Net.WebSockets.Client.Tests.dll (found 53 of 87 test cases)
[20:06:15] info: Starting:    System.Net.WebSockets.Client.Tests.dll
[20:07:51] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'ws://074bf40fe279493f8fb2a570a8bfbea8/' failed: WebSocket is closed before the connection is established.
[20:10:00] fail: [FAIL] System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.SendReceive_VaryingLengthBuffers_Success(server: ws://127.0.0.1:34693/WebSocket/EchoWebSocket.ashx)
[20:10:00] info: System.OperationCanceledException : The operation was canceled.
[20:10:00] info:    at System.Threading.Channels.AsyncOperation`1[[System.Net.WebSockets.ReceivePayload, System.Net.WebSockets.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].GetResult(Int16 token)
[20:10:00] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.WebSocket.ReceiveAsync(Memory`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.ReceiveAsync(WebSocket ws, ArraySegment`1 arraySegment, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_VaryingLengthBuffers_Success(Uri server)
[20:10:00] info: --- End of stack trace from previous location ---
[20:11:11] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'ws://127.0.0.1:34693/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[20:11:12] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'wss://127.0.0.1:41047/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[20:11:42] info: Finished:    System.Net.WebSockets.Client.Tests.dll
[20:11:42] info: 
[20:11:42] info: === TEST EXECUTION SUMMARY ===
[20:11:42] info: Total: 89, Errors: 0, Failed: 1, Skipped: 0, Time: 327.6009649s

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53905-merge-5a8d9815e63046a192/System.Net.WebSockets.Client.Tests/console.608b53e4.log?sv=2019-07-07&se=2021-06-29T19%3A48%3A07Z&sr=c&sp=rl&sig=pEysk8NCg3vGVdQFHK7K1Q12bdrdQ83pA6K9hLXcrb0%3D

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1179573&view=logs&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4

Configuration: Build Browser wasm Release AllSubsets_Mono

@ghost
Copy link

ghost commented Jun 9, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
[20:06:15] info: Discovering: System.Net.WebSockets.Client.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:06:15] info: Discovered:  System.Net.WebSockets.Client.Tests.dll (found 53 of 87 test cases)
[20:06:15] info: Starting:    System.Net.WebSockets.Client.Tests.dll
[20:07:51] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'ws://074bf40fe279493f8fb2a570a8bfbea8/' failed: WebSocket is closed before the connection is established.
[20:10:00] fail: [FAIL] System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.SendReceive_VaryingLengthBuffers_Success(server: ws://127.0.0.1:34693/WebSocket/EchoWebSocket.ashx)
[20:10:00] info: System.OperationCanceledException : The operation was canceled.
[20:10:00] info:    at System.Threading.Channels.AsyncOperation`1[[System.Net.WebSockets.ReceivePayload, System.Net.WebSockets.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].GetResult(Int16 token)
[20:10:00] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.WebSocket.ReceiveAsync(Memory`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.ReceiveAsync(WebSocket ws, ArraySegment`1 arraySegment, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_VaryingLengthBuffers_Success(Uri server)
[20:10:00] info: --- End of stack trace from previous location ---
[20:11:11] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'ws://127.0.0.1:34693/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[20:11:12] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'wss://127.0.0.1:41047/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[20:11:42] info: Finished:    System.Net.WebSockets.Client.Tests.dll
[20:11:42] info: 
[20:11:42] info: === TEST EXECUTION SUMMARY ===
[20:11:42] info: Total: 89, Errors: 0, Failed: 1, Skipped: 0, Time: 327.6009649s

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53905-merge-5a8d9815e63046a192/System.Net.WebSockets.Client.Tests/console.608b53e4.log?sv=2019-07-07&se=2021-06-29T19%3A48%3A07Z&sr=c&sp=rl&sig=pEysk8NCg3vGVdQFHK7K1Q12bdrdQ83pA6K9hLXcrb0%3D

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1179573&view=logs&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4

Configuration: Build Browser wasm Release AllSubsets_Mono

Author: ViktorHofer
Assignees: -
Labels:

area-System.Net

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 9, 2021
@karelz karelz added the arch-wasm WebAssembly architecture label Jun 15, 2021
@ghost
Copy link

ghost commented Jun 15, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
[20:06:15] info: Discovering: System.Net.WebSockets.Client.Tests.dll (method display = ClassAndMethod, method display options = None)
[20:06:15] info: Discovered:  System.Net.WebSockets.Client.Tests.dll (found 53 of 87 test cases)
[20:06:15] info: Starting:    System.Net.WebSockets.Client.Tests.dll
[20:07:51] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'ws://074bf40fe279493f8fb2a570a8bfbea8/' failed: WebSocket is closed before the connection is established.
[20:10:00] fail: [FAIL] System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.SendReceive_VaryingLengthBuffers_Success(server: ws://127.0.0.1:34693/WebSocket/EchoWebSocket.ashx)
[20:10:00] info: System.OperationCanceledException : The operation was canceled.
[20:10:00] info:    at System.Threading.Channels.AsyncOperation`1[[System.Net.WebSockets.ReceivePayload, System.Net.WebSockets.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].GetResult(Int16 token)
[20:10:00] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.WebSocket.ReceiveAsync(Memory`1 buffer, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.ReceiveAsync(WebSocket ws, ArraySegment`1 arraySegment, CancellationToken cancellationToken)
[20:10:00] info:    at System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_VaryingLengthBuffers_Success(Uri server)
[20:10:00] info: --- End of stack trace from previous location ---
[20:11:11] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'ws://127.0.0.1:34693/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[20:11:12] info: http://127.0.0.1:34693/dotnet.js 0 WebSocket connection to 'wss://127.0.0.1:41047/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[20:11:42] info: Finished:    System.Net.WebSockets.Client.Tests.dll
[20:11:42] info: 
[20:11:42] info: === TEST EXECUTION SUMMARY ===
[20:11:42] info: Total: 89, Errors: 0, Failed: 1, Skipped: 0, Time: 327.6009649s

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53905-merge-5a8d9815e63046a192/System.Net.WebSockets.Client.Tests/console.608b53e4.log?sv=2019-07-07&se=2021-06-29T19%3A48%3A07Z&sr=c&sp=rl&sig=pEysk8NCg3vGVdQFHK7K1Q12bdrdQ83pA6K9hLXcrb0%3D

Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1179573&view=logs&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4

Configuration: Build Browser wasm Release AllSubsets_Mono

Author: ViktorHofer
Assignees: -
Labels:

arch-wasm, area-System.Net, untriaged

Milestone: -

@lewing lewing added this to the 6.0.0 milestone Jun 17, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@lewing
Copy link
Member

lewing commented Jun 17, 2021

Not sure what is going on here @pavelsavara can you take a look?

@karelz
Copy link
Member

karelz commented Jun 17, 2021

Note: There is also bunch of similar failures of this test, but perhaps that has been already addressed?

System.Net.WebSockets.WebSocketException : Unable to connect to the remote server
---- System.Net.Http.HttpRequestException : Unknown error (0xffffffff) (corefx-net-http11.azurewebsites.net:443)
-------- System.Net.Sockets.SocketException : Unknown error (0xffffffff)

Data from 4/18-6/17 (incl. PRs) -- Mono failures all, mostly wasm:

Date Build Notes
5/18 PR #52923 System.OperationCanceledException : The operation was canceled.
5/19 official test run 16x - WebSocketException : Unable to connect to the remote server (Mono, not wasm)
5/20-6/2 PR #53027 143x - mix of failures (100x Mono, not wasm), incl. 5x State immediately after ConnectAsync incorrect: Closed
5/26 official test run 29x - WebSocketException : Unable to connect to the remote server (Mono, not wasm)
5/26 PR #53277 15x - WebSocketException : Unable to connect to the remote server
1x State immediately after ConnectAsync incorrect: Closed
(Mono, not wasm)
5/26-5/27 PR #53280 48x - WebSocketException : Unable to connect to the remote server (Mono, not wasm)
6/9 official test run System.OperationCanceledException : The operation was canceled.
6/9 PR #53905 System.OperationCanceledException : The operation was canceled.
6/9 PR #53023 System.OperationCanceledException : The operation was canceled.
6/0 PR #49876 System.OperationCanceledException : The operation was canceled.
6/11 PR #53644 System.OperationCanceledException : The operation was canceled.
6/12 PR #54089 System.Net.WebSockets.WebSocketException : The WebSocket is in an invalid state ('Aborted') for this operation. Valid states are: 'Connecting, Open, CloseReceived, CloseSent'
6/13 PR #54124 System.OperationCanceledException : The operation was canceled.
6/14 PR #54136 System.OperationCanceledException : The operation was canceled.
6/14 PR #52510 System.OperationCanceledException : The operation was canceled.
6/15 PR #53294 System.OperationCanceledException : The operation was canceled.
6/15 PR #54053 System.OperationCanceledException : The operation was canceled.
6/16 PR #54286 System.OperationCanceledException : The operation was canceled.

@pavelsavara
Copy link
Member

error 0xffffffff is already captured here #53281

@pavelsavara
Copy link
Member

Running this locally in tight loop I was able to only reproduce

Retry after attempt #1 failed with System.Net.WebSockets.WebSocketException (0x80004005): Unable to connect to the remote server
 ---> System.Net.WebSockets.WebSocketException (0x80004005): An internal WebSocket error occurred. Please see the innerException, if present, for more details.
   at System.Net.WebSockets.BrowserWebSocket.ConnectAsyncJavaScript(Uri uri, CancellationToken cancellationToken, List`1 requestedSubProtocols)
   at System.Net.WebSockets.BrowserWebSocket.ConnectAsyncJavaScript(Uri uri, CancellationToken cancellationToken, List`1 requestedSubProtocols)
   at System.Net.WebSockets.WebSocketHandle.ConnectAsync(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
   at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken)
   at System.Net.WebSockets.Client.Tests.WebSocketHelper.<>c__DisplayClass4_0.<<GetConnectedWebSocket>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.Net.WebSockets.Client.Tests.WebSocketHelper.<Retry>d__5`1[[System.Net.WebSockets.ClientWebSocket, System.Net.WebSockets.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].MoveNext()

@pavelsavara
Copy link
Member

With timeout down to 3000ms

  info: http://127.0.0.1:49635/dotnet.js 0 WebSocket connection to 'wss://127.0.0.1:49636/WebSocket/EchoWebSocket.ashx' failed: WebSocket is closed before the connection is established.
  fail: [FAIL] System.Net.WebSockets.Client.Tests.ArraySegmentSendReceiveTest.SendReceive_VaryingLengthBuffers_Success(server: wss://127.0.0.1:49636/WebSocket/EchoWebSocket.ashx)
  info: System.Threading.Tasks.TaskCanceledException : A task was canceled.
  info:    at System.Net.WebSockets.BrowserWebSocket.ConnectAsyncJavaScript(Uri uri, CancellationToken cancellationToken, List`1 requestedSubProtocols)
  info:    at System.Net.WebSockets.WebSocketHandle.ConnectAsync(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
  info:    at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken)
  info:    at System.Net.WebSockets.Client.Tests.WebSocketHelper.<>c__DisplayClass4_0.<<GetConnectedWebSocket>b__0>d.MoveNext()
  info: --- End of stack trace from previous location ---
  info:    at System.Net.WebSockets.Client.Tests.WebSocketHelper.<Retry>d__5`1[[System.Net.WebSockets.ClientWebSocket, System.Net.WebSockets.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].MoveNext()
  info:    at System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_VaryingLengthBuffers_Success(Uri server)
  info: --- End of stack trace from previous location ---

@pavelsavara pavelsavara changed the title SendReceive_VaryingLengthBuffers_Success failing in CI [wasm] SendReceive_VaryingLengthBuffers_Success failing in CI Jun 24, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 15, 2021
@radical
Copy link
Member

radical commented Jul 19, 2021

I'm seeing this again in #55899, which includes the fix from #54453.

Log
Build

[06:29:20] info: Starting:    System.Net.WebSockets.Client.Tests.dll
[06:30:52] info: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'ws://127.0.0.1:35747/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[06:30:53] info: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'wss://127.0.0.1:36447/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[06:33:26] fail: [FAIL] System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.SendReceive_VaryingLengthBuffers_Success(server: ws://127.0.0.1:35747/WebSocket/EchoWebSocket.ashx)
[06:33:26] info: System.OperationCanceledException : The operation was canceled.
[06:33:26] info:    at System.Threading.Channels.AsyncOperation`1[[System.Net.WebSockets.ReceivePayload, System.Net.WebSockets.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].GetResult(Int16 token) in System.Threading.Channels.dll:token 0x600001d+0x53
[06:33:26] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken) in System.Net.WebSockets.Client.dll:token 0x6000049+0x1e1
[06:33:26] info:    at System.Net.WebSockets.BrowserWebSocket.ReceiveAsync(ArraySegment`1 buffer, CancellationToken cancellationToken) in System.Net.WebSockets.Client.dll:token 0x6000049+0x2b4
[06:33:26] info:    at System.Net.WebSockets.WebSocket.ReceiveAsync(Memory`1 buffer, CancellationToken cancellationToken) in System.Net.WebSockets.dll:token 0x600005a+0x97
[06:33:26] info:    at System.Net.WebSockets.Client.Tests.MemorySendReceiveTest.ReceiveAsync(WebSocket ws, ArraySegment`1 arraySegment, CancellationToken cancellationToken) in System.Net.WebSockets.Client.Tests.dll:token 0x600012c+0x87
[06:33:26] info:    at System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_VaryingLengthBuffers_Success(Uri server) in System.Net.WebSockets.Client.Tests.dll:token 0x600013a+0x23a
[06:33:26] info: --- End of stack trace from previous location ---
[06:34:40] fail: [out of order message from the browser]: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'ws://127.0.0.1:35747/WebSocket/EchoWebSocket.ashx?subprotocol=CustomProtocol' failed: Error during WebSocket handshake: Response must not include 'Sec-WebSocket-Protocol' header if not present in request: CustomProtocol
[06:34:50] fail: [out of order message from the browser]: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'wss://127.0.0.1:36447/WebSocket/EchoWebSocket.ashx?subprotocol=CustomProtocol' failed: Error during WebSocket handshake: Response must not include 'Sec-WebSocket-Protocol' header if not present in request: CustomProtocol
[06:34:51] info: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'ws://127.0.0.1:42637/' failed: WebSocket is closed before the connection is established.
[06:35:00] info: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'ws://a3b37ae5bfa94d849b08f02430a1a365/' failed: WebSocket is closed before the connection is established.
[06:35:11] info: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'ws://127.0.0.1:35747/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[06:35:11] info: http://127.0.0.1:35747/dotnet.js 0 WebSocket connection to 'wss://127.0.0.1:36447/WebSocket/EchoWebSocket.ashx?delay10sec' failed: WebSocket is closed before the connection is established.
[06:35:11] info: Finished:    System.Net.WebSockets.Client.Tests.dll

@lewing
Copy link
Member

lewing commented Jul 19, 2021

cc @kg

Pavel is out of office this week.

@radical

This comment has been minimized.

@stephentoub

This comment has been minimized.

@karelz
Copy link
Member

karelz commented Jul 20, 2021

It started failing after it was re-enabled on 7/15 in PR #54453:

Day Failures
7/1 1x PR
7/15 2x PR
7/16 6x PR
7/17 1x Official run + 1x PR
7/18 1x PR
7/19 3x PR
7/20 1x Official run + 9x PR
7/21 1x Official run + 8x PR
7/22 1x Official run (WebSocketException) + 1x PR
7/23 4x PR (!x WebSocketException)
7/24 1x PR
7/26 1x Official run + 1x PR (incomplete day info)

I think the test needs to be disabled again ...

Alternative failure "WebSocketException":

System.Net.WebSockets.WebSocketException : The WebSocket is in an invalid state ('Aborted') for this operation. Valid states are: 'Connecting, Open, CloseReceived, CloseSent'

   at System.Net.WebSockets.WebSocket.ThrowOnInvalidState(WebSocketState state, WebSocketState[] validStates) in System.Net.WebSockets.dll:token 0x600005f+0x32
   at System.Net.WebSockets.BrowserWebSocket.CloseAsync(WebSocketCloseStatus closeStatus, String statusDescription, CancellationToken cancellationToken) in System.Net.WebSockets.Client.dll:token 0x600004b+0xe
--- End of stack trace from previous location ---
   at System.Net.WebSockets.Client.Tests.SendReceiveTest.SendReceive_VaryingLengthBuffers_Success(Uri server) in System.Net.WebSockets.Client.Tests.dll:token 0x600013a+0x34e
--- End of stack trace from previous location ---

@karelz
Copy link
Member

karelz commented Jul 26, 2021

@kg @lewing can you please disable the test? It seems to be failing rather often ...

@pavelsavara
Copy link
Member

pavelsavara commented Jul 26, 2021

Disable failing test #56293

@karelz karelz added the disabled-test The test is disabled in source code against the issue label Jul 26, 2021
@pavelsavara
Copy link
Member

I'm able to reproduce it locally if I decrease timeout or run the body of the test in a loop many times. So, now I think that it's a consequence of timeout. But the timeout is 30s for a test here, so I'm not clear if the CI machine could be so slow.

@pavelsavara
Copy link
Member

pavelsavara commented Aug 18, 2021

And also in CI

System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: ws://127.0.0.1:49261/WebSocket/EchoWebSocket.ashx)

Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   (No exception was thrown)

@kg
Copy link
Contributor

kg commented Aug 18, 2021

Is there a way for us to identify whether a timeout happened deeper in the stack (i.e. a browser quirk or issue with the server) vs inside our code? I feel like it's possible the intermittent failures here aren't our fault and could be due to something about how we're running these tests, but we'd need some way to verify that.

@pavelsavara
Copy link
Member

WASM network tests are running with echo server inside xharness process, which is different process on the same machine.

For part of HTTP tests, we are talking directly to the xharness kestrel.
(That is, not via internet, as opposed to coreCLR tests)

For the Loopback part of the tests, we are unable to implement loopback directly on the WASM and therefore we use WebSockets to control the remote loop on the xharness process.
(That is, not in the same process as opposed to coreCLR tests)

On top of that we have extra layer of browser networking stack.

Also, our WS implementation has extra layer of buffering between WASM and browser. #44614

I will try to run SendReceive_VaryingLengthBuffers_Success in tight loop to see if I can figure out more details of that behavior.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 1, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 16, 2021
@ilonatommy
Copy link
Member

@pavelsavara, did you get any more details when running SendReceive_VaryingLengthBuffers_Success as planned?

@pavelsavara
Copy link
Member

not really, but maybe this could be related to the issue we found with @maraf yesterday ?

pavelsavara added a commit to pavelsavara/runtime that referenced this issue Jul 26, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 26, 2022
pavelsavara added a commit that referenced this issue Jul 27, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 27, 2022
@dotnet dotnet locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net disabled-test The test is disabled in source code against the issue
Projects
None yet
8 participants