Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failed '((emitThisGCrefRegs | emitThisByrefRegs) & regMask) && (ins == INS_inc || ins == INS_dec || ins == INS_inc_l || ins == INS_dec_l)' #54007

Closed
BruceForstall opened this issue Jun 10, 2021 · 14 comments
Closed

Assertion failed '((emitThisGCrefRegs | emitThisByrefRegs) & regMask) && (ins == INS_inc || ins == INS_dec || ins == INS_inc_l || ins == INS_dec_l)' #54007

BruceForstall opened this issue Jun 10, 2021 · 14 comments
Assignees
@BruceForstall
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
6.0.0

Comments

@BruceForstall
Copy link
Member

Failure in runtime-coreclr libraries-jitstress pipeline, System.IO.Hashing.Tests, x86/x64, multiple stress modes:

https://dev.azure.com/dnceng/public/_build/results?buildId=1180694&view=ms.vss-test-web.build-test-results-tab&runId=35530936&resultId=178029&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

----- start Thu Jun 10 08:11:49 UTC 2021 =============== To repro directly: =====================================================
pushd .
/datadisks/disk1/work/9E8D08E8/p/dotnet exec --runtimeconfig System.IO.Hashing.Tests.runtimeconfig.json --depsfile System.IO.Hashing.Tests.deps.json xunit.console.dll System.IO.Hashing.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/datadisks/disk1/work/9E8D08E8/w/B45109C0/e /datadisks/disk1/work/9E8D08E8/w/B45109C0/e
  Discovering: System.IO.Hashing.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.IO.Hashing.Tests (found 153 test cases)
  Starting:    System.IO.Hashing.Tests (parallel test collections = on, max threads = 2)

Assert failure(PID 25624 [0x00006418], Thread: 25638 [0x6426]): Assertion failed '((emitThisGCrefRegs | emitThisByrefRegs) & regMask) && (ins == INS_inc || ins == INS_dec || ins == INS_inc_l || ins == INS_dec_l)' in 'System.IO.Hashing.Tests.NonCryptoHashTestDriver:InstanceMultiAppendGetCurrentHashDriver(TestCase):this' during 'Emit code' (IL size 172)

    File: /__w/1/s/src/coreclr/jit/emitxarch.cpp Line: 11749
    Image: /datadisks/disk1/work/9E8D08E8/p/dotnet

Gathering state for process 25624 dotnet
Writing minidump with heap to file /home/helixbot/dotnetbuild/dumps/coredump.25624.dmp
Written 134455296 bytes (32826 pages) to core file
Dump successfully written
./RunTests.sh: line 162: 25624 Aborted                 (core dumped) "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.IO.Hashing.Tests.runtimeconfig.json --depsfile System.IO.Hashing.Tests.deps.json xunit.console.dll System.IO.Hashing.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
/datadisks/disk1/work/9E8D08E8/w/B45109C0/e
----- end Thu Jun 10 08:11:57 UTC 2021 ----- exit code 134 ----------------------------------------------------------

@dotnet/jit-contrib
@BruceForstall BruceForstall added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 10, 2021
@BruceForstall BruceForstall added this to the 6.0.0 milestone Jun 10, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 10, 2021
@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Jun 10, 2021
@tannergooding
Copy link
Member

I wonder if this is similar to #10821 and #51728

The APIs here are making decently heavy use of Span<T> and this is a similar assert that an operation that is expected on a byref isn't on a byref.

@BruceForstall
Copy link
Member Author

This is new code, as of #53623.

cc @bartonjs The new test tickles some JIT bug under optimization.

@BruceForstall BruceForstall self-assigned this Jun 12, 2021
@BruceForstall
Copy link
Member Author

@tannergooding It looks like you're right. The stackalloc creates a long, then there's a silly amount of var=var that is byref, followed by add:

N565 (  2,  5) [000064] ---X---N----        t64 = *  LCLHEAP   long   REG rdi $484
                                                  /--*  t64    long
N567 (  2,  5) [000567] DA-X--------              *  STORE_LCL_VAR long   V50 tmp40        d:2 rdi REG rdi
N569 (???,???) [002056] ------------                 IL_OFFSET void   IL offset: 0x4f REG NA
N571 (  1,  1) [000572] ------------       t572 =    LCL_VAR   byref  V50 tmp40        u:2 rdi (last use) REG rdi $484
                                                  /--*  t572   byref
N573 (  5,  4) [000551] DA----------              *  STORE_LCL_VAR byref  V158 tmp148      d:2 rdi REG rdi
N575 (???,???) [002057] ------------                 IL_OFFSET void   IL offset: 0x4f REG NA
N577 (  3,  2) [001609] -------N----      t1609 =    LCL_VAR   byref  V158 tmp148      u:2 rdi (last use) REG rdi $484
                                                  /--*  t1609  byref
N579 (  7,  5) [001610] DA----------              *  STORE_LCL_VAR byref  V139 tmp129      d:2 rdi REG rdi
N581 (???,???) [002058] ------------                 IL_OFFSET void   IL offset: 0x4f REG NA
N583 (???,???) [002059] ------------                 IL_OFFSET void   IL offset: 0x61 REG NA
N585 (  3,  2) [001612] ------------      t1612 =    LCL_VAR   byref  V139 tmp129      u:2 rdi (last use) REG rdi $484
                                                  /--*  t1612  byref
N587 (  7,  5) [001613] DA----------              *  STORE_LCL_VAR byref  V133 tmp123      d:2 rdi REG rdi
N589 (???,???) [002060] ------------                 IL_OFFSET void   IL offset: 0x63 REG NA
N591 (  3,  2) [001619] ------------      t1619 =    LCL_VAR   byref  V133 tmp123      u:2 rdi (last use) REG rdi $484
                                                  /--*  t1619  byref
N593 (  7,  5) [001620] DA----------              *  STORE_LCL_VAR byref  V127 tmp117      d:2 rdi REG rdi
N595 (???,???) [002061] ------------                 IL_OFFSET void   IL offset: 0x66 REG NA
N597 (  3,  2) [000582] ------------       t582 =    LCL_VAR   byref  V127 tmp117      u:2 rdi (last use) REG rdi $484
                                                  /--*  t582   byref
N599 (  3,  3) [000613] DA--G-------              *  STORE_LCL_VAR byref  V53 tmp43        d:2 rdi REG rdi
N601 (???,???) [002062] ------------                 IL_OFFSET void   IL offset: 0x66 REG NA
N603 (???,???) [002063] ------------                 IL_OFFSET void   IL offset: 0x66 REG NA
N605 (  1,  4) [001982] -c----------      t1982 =    CNS_INT   int    255 REG NA $5a
                                                  /--*  t1982  int
N607 (  1,  4) [000640] DA----------              *  STORE_LCL_VAR int    V54 tmp44        d:2 rcx REG rcx
N609 (???,???) [002064] ------------                 IL_OFFSET void   IL offset: 0x66 REG NA
N611 (???,???) [002065] ------------                 IL_OFFSET void   IL offset: 0x66 REG NA
N613 (???,???) [002066] ------------                 IL_OFFSET void   IL offset: 0x66 REG NA
N615 (???,???) [002067] ------------                 IL_OFFSET void   IL offset: 0x66 REG NA
N617 (  1,  1) [000610] ------------       t610 =    LCL_VAR   byref  V53 tmp43        u:2 rdi (last use) REG rdi $484
N619 (  1,  1) [000609] -c----------       t609 =    CNS_INT   long   1 REG NA $104
                                                  /--*  t610   byref
                                                  +--*  t609   long
N621 (  3,  3) [000611] ------------       t611 = *  ADD       byref  REG rdi $187

@BruceForstall
Copy link
Member Author

@tannergooding @bartonjs Can we disable the appropriate tests under Checked runtime / JIT stress modes? How do we do that?

@tannergooding
Copy link
Member

I'm not aware of how to disable a libraries test for a given CI leg (such as JIT stress). @ViktorHofer do we have this capability today?

@BruceForstall
Copy link
Member Author

Well, I tried using:

[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/54007", RuntimeConfiguration.Checked)]

but couldn't get it to work.

Maybe @safern has a suggestion?

@safern
Copy link
Member

safern commented Jun 14, 2021

[SkipOnCoreClr("https://github.com//issues/54007", RuntimeConfiguration.Checked)]

That should've worked. The logic is pretty "simple" to skip on that case: https://github.com/dotnet/arcade/blob/398bdff17042af6ae8131a661860b13ef247ecff/src/Microsoft.DotNet.XUnitExtensions/src/Discoverers/SkipOnCoreClrDiscoverer.cs#L50

Let me know if you can't get it to work and I can see what's going on with the discoverer.

@BruceForstall
Copy link
Member Author

@tannergooding I presume this issue will get fixed with your #53684? (Assuming you fix that PR and get it back in.)

@tannergooding
Copy link
Member

I presume this issue will get fixed with your #53684? (Assuming you fix that PR and get it back in.)

@BruceForstall It should. However, there is more testing and work I have to do to determine "why" my fix isn't "complete" (and since I'm largely only working on it in my spare time, I'm not sure when I'll get it finalized).

As is, it looks like the change might be more complicated because eliding no moves (that is preserving every "redundant" move and just emitting the assembly for it) looks to cause problems, which leads me to believe there are some more complicated liveness issues here and that might be what's causing my original PR to fail under certain stress environments.

@BruceForstall
Copy link
Member Author

@safern In #54207 I tried to disable all the tests that call System.IO.Hashing.Tests.NonCryptoHashTestDriver:InstanceMultiAppendGetCurrentHashDriver using SkipOnCoreClr but apparently I either didn't do it right, or that function is getting called in some other way.

@safern
Copy link
Member

safern commented Jun 15, 2021

Hmm interesting, I think that might need some debugging. I can try looking at it, but I have some stuff to get out of my way first.

@ViktorHofer
Copy link
Member

I'm not aware of how to disable a libraries test for a given CI leg (such as JIT stress). @ViktorHofer do we have this capability today?

Sorry for the late reply, I was OOF yesterday. Looks like @safern is already on it.

BruceForstall added a commit to BruceForstall/runtime that referenced this issue Jun 18, 2021
@BruceForstall
Disable tests for dotnet#54007
9ba88e9
@BruceForstall BruceForstall mentioned this issue Jun 18, 2021
Merged
@BruceForstall
Copy link
Member Author

Looks like I just missed one case. The "disable" PR is now up for review.

BruceForstall added a commit that referenced this issue Jun 19, 2021
@BruceForstall
Disable tests for #54007 (#54207)
9c5581c
radical added a commit to radical/runtime that referenced this issue Jun 30, 2021
@radical
Squashed commit of the following:
50ef2a7 
commit 14747dcf058a2129bbbcafacfd8f8adbc47ffef9
Merge: fb9b27c1fb0 118c530
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 25 20:48:51 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads

commit fb9b27c1fb006556d9b71cee6663088c88d17c38
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 25 15:15:26 2021 -0400

    Fix remaining tests

commit 6d43522dbac7768d33b18c4004a7d148d15154df
Merge: 42e42afaedf fc4a427
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 25 12:03:53 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads

commit 42e42afaedf4c9fb29b93840163f7f6283d030a5
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 25 01:55:52 2021 -0400

    copy nuget.config for blazor test too

commit 4456b1a3dc00e9b5ec7d129c3498d774f789a0d0
Author: Ankit Jain <radical@gmail.com>
Date:   Fri Jun 25 00:33:57 2021 -0400

    fix build

commit ccc2c89c403a7349eb6bb9debccfed4e729e5bb8
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 23:33:13 2021 -0400

    Isolate the nuget environment

commit 53adc7d55c700795f3cbabaf64200a319afec525
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 20:11:51 2021 -0400

    Bump sdk for workloads to 6.0.100-preview.6.21324.1

commit fbaf2ce408cf53dab2b4db5348e353b037a1a90b
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 20:09:30 2021 -0400

    fix tests

commit ba8b922e055547ff9373391a1f215487ed9240a5
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 18:50:14 2021 -0400

    skip first time experience

commit a07a59586e8482871fb0ed71877b8853e8e3fb41
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 18:47:38 2021 -0400

    fix build error

commit c1487458f7defe608c7a3eaaddc5ea671dc4456d
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 18:45:49 2021 -0400

    fix nuget error

commit 5199e9ce862e7fba7dee1d930e81915fbc5a503c
Merge: 0c68049b6ca 1e5ebfed32e
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 17:59:13 2021 -0400

    Merge branch 'wasm-native-libs-workloads-pr' into wasm-native-libs-workloads

commit 1e5ebfed32e4c22f6c33a5ad622375c138123d86
Merge: 643c8212d8f c88da29
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 16:49:24 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads-pr

commit 643c8212d8f2bb45684531d3445e12c75c37839c
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 16:49:22 2021 -0400

    fix linux build

commit 9b064d96dc8de5a21afc994c8efc4d7c27d88729
Merge: 5fd632f031a abccfad
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 12:20:39 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads-pr

commit 5fd632f031a854bf36d98a7647c7ef6e15d5ae59
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 12:12:18 2021 -0400

    fix casing for runtime pack path

commit b4d48f37bbaa4a899e2444aac47e1d550bbad23b
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 02:33:09 2021 -0400

    fix runscript

commit 0c68049b6cac1fabce76af950d6c15c01d9952e1
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 02:15:49 2021 -0400

    refactorings

commit 425e2e3c8f84ba1f536a134b70941f939942a1ae
Author: Ankit Jain <radical@gmail.com>
Date:   Thu Jun 24 01:20:16 2021 -0400

    set sdk path for helix

commit 9652f8b82a5e000dadc2e9bf0015ab769d1faae7
Merge: 999de6d4441 dae9156
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 23 23:46:59 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads

commit 999de6d44419ca804ffabc719eba02c6b1ed230e
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 23 23:19:42 2021 -0400

    Add missing UsingTask

commit 7636d3823db3f9e6e3223a22ba5ef57e99c6e641
Merge: 2468045aedc 4f3e30e
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 23 22:21:38 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads

commit 2468045aedcece825bbba39a8163c97bdc796fd7
Merge: 16c83d7d62b f3af8d8
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 23 21:23:55 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads

commit 16c83d7d62b91499a51a81dac63ce8f60ee16d83
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 23 21:23:48 2021 -0400

    Add hack to manually generate sdk.props for the cross compiler

commit 8f9ddfbfced4fbf512df59648fa08df15c2f6bb1
Merge: 57b2950ba4a 0416c34
Author: Ankit Jain <radical@gmail.com>
Date:   Wed Jun 23 12:59:32 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads

commit 57b2950ba4a10f66d7aedcf497579a5e8c64ae9d
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 19:21:51 2021 -0400

    trying to fix the build

commit 63089822f25848d190ab1d8b06468c293e2b9d2a
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 15:38:09 2021 -0400

    Don't build Wasm.Build.Tests for linker-tests pipeline

commit 49d5dba9783694a8f57c621e020bfb481ee8971f
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 15:34:34 2021 -0400

    Make sure to restore runtime pack project

commit fb4348b38b6061be1a64a2112fed9a8615dbb840
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 14:36:50 2021 -0400

    disable Microsoft.NETCore.Platforms.Tests on wasm

    This is already not being sent to CI with `IgnoreForCI=true`.
    It fails on CI with:

    ```
    /_/src/Shared/NativeMethodsShared.cs(855,29): error IL1005: Microsoft.Build.Shared.NativeMethodsShared.SystemInformation.get: Error processing method 'Microsoft.Build.Shared.NativeMethodsShared.SystemInformationData.SystemInformationData()' in assembly 'Microsoft.Build.Utilities.Core.dll' [/__w/1/s/src/libraries/Microsoft.NETCore.Platforms/tests/Microsoft.NETCore.Platforms.Tests.csproj]
    \##[error]/_/src/Shared/NativeMethodsShared.cs(855,29): error IL1005: (NETCORE_ENGINEERING_TELEMETRY=Build) Microsoft.Build.Shared.NativeMethodsShared.SystemInformation.get: Error processing method 'Microsoft.Build.Shared.NativeMethodsShared.SystemInformationData.SystemInformationData()' in assembly 'Microsoft.Build.Utilities.Core.dll'
      Mono.Linker.LinkerFatalErrorException: /_/src/Shared/NativeMethodsShared.cs(855,29): error IL1005: Microsoft.Build.Shared.NativeMethodsShared.SystemInformation.get: Error processing method 'Microsoft.Build.Shared.NativeMethodsShared.SystemInformationData.SystemInformationData()' in assembly 'Microsoft.Build.Utilities.Core.dll'
       ---> System.NotImplementedException: switch
         at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.IsConstantBranch(OpCode opCode, Int32 operand) in illink.dll:token 0x6000770+0x41
         at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RemoveConditions() in illink.dll:token 0x6000768+0x22a
         at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RewriteBody() in illink.dll:token 0x6000766+0xa
         at Mono.Linker.Steps.UnreachableBlocksOptimizer.ProcessStack() in illink.dll:token 0x60004e9+0x102
         at Mono.Linker.Steps.UnreachableBlocksOptimizer.ProcessMethod(MethodDefinition method) in illink.dll:token 0x60004e5+0x44
         at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method, DependencyInfo& reason, Scope& scope) in illink.dll:token 0x600040e+0x9b
         at Mono.Linker.Steps.MarkStep.ProcessQueue() in illink.dll:token 0x6000399+0x24
         --- End of inner exception stack trace ---
         at Mono.Linker.Steps.MarkStep.ProcessQueue() in illink.dll:token 0x6000399+0xaa
         at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue() in illink.dll:token 0x6000396+0xa
         at Mono.Linker.Steps.MarkStep.Process() in illink.dll:token 0x6000393+0x0
         at Mono.Linker.Steps.MarkStep.Process(LinkContext context) in illink.dll:token 0x600038a+0x41
         at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step) in illink.dll:token 0x6000264+0x0
         at Mono.Linker.Pipeline.Process(LinkContext context) in illink.dll:token 0x6000263+0xf
         at Mono.Linker.Driver.Run(ILogger customLogger) in illink.dll:token 0x60000fd+0x20
      Optimizing assemblies for size, which may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
    /__w/1/s/.dotnet/sdk/6.0.100-preview.4.21255.9/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(80,5): error NETSDK1144: Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false. [/__w/1/s/src/libraries/Microsoft.NETCore.Platforms/tests/Microsoft.NETCore.Platforms.Tests.csproj]
    \##[error].dotnet/sdk/6.0.100-preview.4.21255.9/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILLink.targets(80,5): error NETSDK1144: (NETCORE_ENGINEERING_TELEMETRY=Build) Optimizing assemblies for size failed. Optimization can be disabled by setting the PublishTrimmed property to false.
    ```

commit 480373505d9e25c361555d9b0506c70da3287dd5
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 14:10:06 2021 -0400

    cleanup

commit 911c54ae28dea7becc7ade908b7ac801bfcc40fa
Merge: f6f8e26b1c6 62b8d02
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 13:26:38 2021 -0400

    Merge remote-tracking branch 'origin/main' into wasm-native-libs-workloads

commit f6f8e26b1c69826a4489482580e9ecaa4b45896b
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 13:20:10 2021 -0400

    Directly invoke runtime pack sfxproj, to get the package

commit 998c83d5f6c062ed3e9c16fe1d67c8bddb940d8b
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 13:03:12 2021 -0400

    cleanup

commit 81373d93eff8e5ee77984f589434693774624823
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 03:27:00 2021 -0400

    Use dotnet6 feed to restore packages

commit c8ca41007128b9ec4723486bee504afc69ac3343
Author: Ankit Jain <radical@gmail.com>
Date:   Tue Jun 22 02:58:02 2021 -0400

    get the version from envvar

commit c66de8622cb4566ff883f6c84cadf0f9bb1a0a7e
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 18:00:04 2021 -0400

    Fix to use the correct ref pack

commit 4554f301941f56731da352393cc525c0c607a69a
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 17:10:04 2021 -0400

    fixes

commit 8f01a0aebe32aa8376be37d61bf10f0a443faac1
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 15:54:51 2021 -0400

    fix tests

commit 99e84734dd415abb3117584c60f2e3c0d5cf4852
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 14:41:49 2021 -0400

    this seems to get the runtime pack building

commit 967d60e06d3206eec83752cea5bb8f0d79961bf4
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 11:42:48 2021 -0400

    fix build

commit 3c1ef3355cf0ec57c16534d52200e31fa5d6fdf6
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 11:24:44 2021 -0400

    fix DirectoryCopy

commit a20102c574528a6835598958730e9c26e655e533
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 08:57:13 2021 -0400

    fix net6.0 test builds

commit 2fa559ec0ed5822834a7c9b0f905e496a4c7c5db
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 08:18:21 2021 -0400

    cleanup

commit 0ffd96cf7d1dbff748512b8d1d3b6548233b2b4e
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 04:23:21 2021 -0400

    debug

commit 8e754bf7650f2ab83d1a45a5e096d8fcaf080fc4
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 03:16:33 2021 -0400

    fix build, move doesn't work on CI - invalid cross-device link

commit 53ec67103d90e3cfda73b5423b6a416b67a58b88
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 02:12:39 2021 -0400

    undo changes to wasm samples

commit 1fe8601850289bf97a1ede3415276773e6eec079
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 02:11:52 2021 -0400

    cleanup

commit 529fb8698165376b6246448ff5be76e6fe4adf54
Author: Eric StJohn <ericstj@microsoft.com>
Date:   Sat Jun 19 13:31:12 2021 -0700

    Remove System.Security.Cryptography.Cng from ASP.NET transport package (dotnet#54428)

commit 04e7a11ecd7eb1826d14634d7c08bff4665b17e9
Author: Bruce Forstall <brucefo@microsoft.com>
Date:   Sat Jun 19 10:07:59 2021 -0700

    Disable tests for dotnet#54007 (dotnet#54207)

commit d0798cd272bb71194a21350da1f10e624bb62fbd
Author: Ankit Jain <radical@gmail.com>
Date:   Sun Jun 20 00:40:56 2021 -0400

    fix running dotnet-install.sh on linux

commit fe05df865629e14b92af6af4233a59ae9ac935cf
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 19 22:46:55 2021 -0400

    fix helix build

commit 3a224d38593e5e60334ff2d1debe26ff395506e8
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 19 09:03:16 2021 -0400

    try helix

commit 5c5212479503aeaef3d7335e5c011e5548f758b5
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 19 05:55:09 2021 -0400

    fix order of args to emcc

commit 84750efbaf73a84596700832c699ddfea73573da
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 19 05:30:35 2021 -0400

    fixed

commit 4e0318f09eaac0113da8a5c82634ef8997b43a46
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 19 04:08:18 2021 -0400

    add BuildEnvironment.cs

commit 0b8766423fc677f44c0580fe21f812d7ff6e9cd4
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 19 02:58:09 2021 -0400

    remove native-libs sample

commit 55cbd78aa21dab49f3daab53a89b092cd05e3761
Author: Ankit Jain <radical@gmail.com>
Date:   Sat Jun 19 02:28:04 2021 -0400

    [wip] wasm native libs, and testing wbt with workloads

Run wasm.build.tests with, and without workloads

cleanup

remove old copy of test

wip

Fix helix job for non-workload run

umm.. wip.. till previous commit, it works on helix..

try to fix non-workloads test run

cleanup, and fix windows command line

cleanup

Remove redundant functional tests

build samples in parallel

Revert Utils.DirectoryCopy, and creat dirs wher needed

fix windows build

fix build

fix dir copy

don't build samples, and functional tests on eat, aot lanes

cleanup

Test with latest sdk (6.0.100-preview.7.21326.4)

rename runscript

trying on windows

add test for checking UnixFilePermissions.xml in the packs

cleanup

cleanup
@kunalspathak kunalspathak mentioned this issue Jun 30, 2021
Merged
@BruceForstall BruceForstall mentioned this issue Jul 8, 2021
Merged
@BruceForstall BruceForstall mentioned this issue Jul 22, 2021
Closed
BruceForstall added a commit to BruceForstall/runtime that referenced this issue Jul 22, 2021
@BruceForstall
Disable JIT xarch asserts on gcref/byref computation
5d20d12 
The emitter has asserts that an xarch RMW inc/dec/add/sub of a byref
must have an incoming gcref/byref to be legal. This is (no longer)
true due to extensive use of Span and Unsafe constructs, where we
often see lclheap or other integer typed values cast to byref. Also,
the emitter only updates its GC info when an instruction is generated.
When one of these casts from integer to byref ends up getting the same
register allocated, and its instruction is thus omitted, the emitter
doesn't get the appropriate gcref update (this problem is being
attempted to be solved elsewhere).

For now, disable these asserts.

Re-enable the tests disabled in dotnet#54207

Fixes dotnet#51728, dotnet#54007
@BruceForstall BruceForstall mentioned this issue Jul 22, 2021
Merged
BruceForstall added a commit that referenced this issue Jul 23, 2021
@BruceForstall
Disable JIT xarch asserts on gcref/byref computation (#56192)
d148c34 
The emitter has asserts that an xarch RMW inc/dec/add/sub of a byref
must have an incoming gcref/byref to be legal. This is (no longer)
true due to extensive use of Span and Unsafe constructs, where we
often see lclheap or other integer typed values cast to byref. Also,
the emitter only updates its GC info when an instruction is generated.
When one of these casts from integer to byref ends up getting the same
register allocated, and its instruction is thus omitted, the emitter
doesn't get the appropriate gcref update (this problem is being
attempted to be solved elsewhere).

For now, disable these asserts.

Re-enable the tests disabled in #54207

Fixes #51728, #54007
@BruceForstall
Copy link
Member Author

Fixed by #56192

@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
4 participants
@ViktorHofer @tannergooding @BruceForstall @safern