[API Proposal]: Add GetDeclaringType to PropertyDefinition and EventDefinition

[MichalStrehovsky]

Background and motivation

S.R.Metadata provides a way to get the owning type of fields and methods. It doesn't provide an API to get owning type of properties and events. I think it should be exposed for parity.

The lookup strategy is similar (a binary search in one of the tables).

API Proposal

namespace System.Reflection.Metadata
{
    public struct PropertyDefinition
    {
        public TypeDefinitionHandle GetDeclaringType();
    }

    public struct EventDefinition
    {
        public TypeDefinitionHandle GetDeclaringType();
    }
}

API Usage

PropertyDefinition someProperty = ...;
var owningType = someProperty.GetDeclaringType();

Risks

No response

[ghost]

Tagging subscribers to this area: @buyaa-n
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and motivation

S.R.Metadata provides a way to get the owning type of fields and methods. It doesn't provide an API to get owning type of properties and events. I think it should be exposed for parity.

The lookup strategy is similar (a binary search in one of the tables).

API Proposal

namespace System.Reflection.Metadata
{
    public struct PropertyDefinition
    {
        public TypeDefinitionHandle GetDeclaringType();
    }

    public struct EventDefinition
    {
        public TypeDefinitionHandle GetDeclaringType();
    }
}

API Usage

PropertyDefinition someProperty = ...;
var owningType = someProperty.GetDeclaringType();

Risks

No response

Author:	MichalStrehovsky
Assignees:	-
Labels:	api-suggestion, area-System.Reflection.Metadata
Milestone:	-

[MichalStrehovsky]

Cc @tmat for a S.R.Metadata new API opinion.

[buyaa-n]

Moving this to 8.0, @MichalStrehovsky please let us know if you need it in 7.0

[tmat]

API looks good to me.

[terrajobst]

Video

• Looks good as proposed

namespace System.Reflection.Metadata;

public partial struct PropertyDefinition
{
    public TypeDefinitionHandle GetDeclaringType();
}

public partial struct EventDefinition
{
    public TypeDefinitionHandle GetDeclaringType();
}

[deeprobin]

I took the liberty to implement this issue (see issue-60380). In retrospect, I realized that it would probably be useful to know a little better about the IL format.

After the implementation quite a few tests fail. I think I did something wrong with the offset calculation. Can anyone help me out here, or does anyone see where the error lies?

https://github.com/deeprobin/runtime/blob/de24b71d687975e8dff8cc03391807372dcedb81/src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/Internal/Tables.cs#L152-L168

I am grateful for any help.

/cc @MichalStrehovsky

[MichalStrehovsky]

I didn't look in detail yet, but at minimum there are two copy-paste bugs in internal TypeDefinitionHandle GetDeclaringType(EventDefinitionHandle eventDef) (using stuff related to properties on events).