Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Update two debugger tests, as they are invalid now #63560

Closed
radical opened this issue Jan 10, 2022 · 2 comments · Fixed by #64652
Closed

[wasm] Update two debugger tests, as they are invalid now #63560

radical opened this issue Jan 10, 2022 · 2 comments · Fixed by #64652
Labels
arch-wasm WebAssembly architecture area-Debugger-mono

Comments

@radical
Copy link
Member

radical commented Jan 10, 2022 •
edited
Loading

ArrayTests.InvalidValueTypeArrayIndex, and ArrayTests.InvalidArrayId

  1. use an older format of the object ids
  2. are incorrect as they are expecting to find a local Container c, but it stops in an instance method of c

Found this in #63528 .
@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels Jan 10, 2022
@ghost
Copy link

ghost commented Jan 10, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

ArrayTests.InvalidValueTypeArrayIndex, and ArrayTests.InvalidArrayId use an older format of the object ids.

Found this in #63528 .

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 10, 2022
@radical radical removed the untriaged New issue has not been triaged by the area owner label Jan 10, 2022
@radical
Copy link
Member Author

radical commented Jan 10, 2022

cc @thaystg

radical added a commit to radical/runtime that referenced this issue Feb 1, 2022
@radical
[wasm][debugger] Update two array tests
eba1515 
`ArrayTests.InvalidValueTypeArrayIndex` isn't needed any more because
array members don't have special ids now.

Fixes dotnet#63560
@radical radical mentioned this issue Feb 1, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 1, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wasm][debugger] Fix some flaky tests radical/runtime
1 participant
@radical