Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Runtime.InteropServices.Tests causing OSX queue backup from uploading dump #65000

Closed
elinor-fung opened this issue Feb 8, 2022 · 6 comments

Comments

@elinor-fung
Copy link
Member

See https://github.com/dotnet/core-eng/issues/15520#issuecomment-1032835597

Going to temporarily disable coredumps for libraries tests on macOS while we investigate more, since this is causing issues for everyone using the queue.

@ghost
Copy link

ghost commented Feb 8, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

See https://github.com/dotnet/core-eng/issues/15520#issuecomment-1032835597

Going to temporarily disable coredumps for libraries tests on macOS while we investigate more, since this is causing issues for everyone using the queue.

Author: elinor-fung
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 8, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT removed the untriaged New issue has not been triaged by the area owner label Feb 8, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 7.0.0 milestone Feb 8, 2022
@agocke
Copy link
Member

agocke commented Feb 8, 2022

Thanks! If this is a reliable repro I could try running it locally.

@elinor-fung
Copy link
Member Author

That would be great. My theory is that we have at least one expected dump from PosixSignalRegistrationTests.SignalCanCancelTermination for SIGQUIT and not cancelling termination:

[InlineData(PosixSignal.SIGQUIT, false, 131)]
public void SignalCanCancelTermination(PosixSignal signal, bool cancel, int expectedExitCode)

If it is that, it should be consistent.

Many of the dumps I see are coming from passed tests. I know @stephentoub had mentioned/reported needing a way to avoid uploading dumps for expected crashes, but I can't seem to find the issue.

WorkItems
| where FriendlyName == "System.Runtime.InteropServices.Tests" and QueueName == "osx.1200.amd64.open" and Queued >= ago(1d)
| join Files on WorkItemId
| where FileName startswith "core"
| project Queued, Status, ExitCode, QueueName, ConsoleUri, SizeBytesLong

@stephentoub
Copy link
Member

Many of the dumps I see are coming from passed tests. I know @stephentoub had mentioned/reported needing a way to avoid uploading dumps for expected crashes, but I can't seem to find the issue.

https://github.com/dotnet/core-eng/issues/15333

@AaronRobinsonMSFT
Copy link
Member

@elinor-fung Was this resolved with https://github.com/dotnet/core-eng/issues/15333?

@elinor-fung
Copy link
Member Author

The immediate issues this was tracking have been addressed/mitigated. The long-term fix is tracked by #65422.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants