Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test with expected crash to outerloop #65114

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Feb 10, 2022

Contributes to #65000

  • Re-enable core dumps on OSX for libraries test runs
  • Move test with expected crash (PosixSignalRegistrationTests.SignalCanCancelTermination with SIGQUIT, not cancelled) to outerloop
  • Disable test with expected crash OSX - trying to upload the core dump will still cause timeouts / leave machines in bad states until we have https://github.com/dotnet/core-eng/issues/15333#issuecomment-1034275061.

@ghost
Copy link

ghost commented Feb 10, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: elinor-fung
Assignees: elinor-fung
Labels:

area-System.Runtime.InteropServices

Milestone: -

@elinor-fung
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My next idea if needed is to serialize such tests, and wrap them in code (flag to remote executor) that deletes any core dumps that did not exist when the test began.

@elinor-fung
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@elinor-fung
Copy link
Member Author

elinor-fung commented Feb 10, 2022

With this, the expected crashes are happening in outerloop. The timeout in runtime-libraries-coreclr outerloop (Libraries Build OSX x64 Debug) is from still trying to upload that 6GB dump. Perhaps we should disable that one case on macOS until we have something for https://github.com/dotnet/core-eng/issues/15333? cc @stephentoub

Jobs
| where Source == "pr/public/dotnet/runtime/refs/pull/65114/merge"
| join kind=inner Files on JobId
| where FileName startswith "core."
| join kind=inner WorkItems on WorkItemId
| where FriendlyName == "System.Runtime.InteropServices.Tests"
| project
  QueueAlias,
  Pipeline = tostring(parse_json(Properties).DefinitionName),
  PhaseName = tostring(parse_json(Properties)["System.PhaseName"]),
  FileName,
  SizeBytesLong
QueueAlias Pipeline PhaseName FileName SizeBytesLong
alpine.314.amd64.open runtime-libraries-coreclr outerloop libraries_build_Linux_musl_x64_Debug core.1000.45 71311360
centos.7.amd64.open runtime-libraries-coreclr outerloop libraries_build_Linux_x64_Debug core.1000.45 161980416
debian.10.amd64.open runtime-libraries-coreclr outerloop libraries_build_Linux_x64_Debug core.1000.40 121303040
osx.1200.amd64.open runtime-libraries-coreclr outerloop libraries_build_OSX_x64_Debug core.85967 6374526976
osx.1200.arm64.open runtime-libraries-coreclr outerloop libraries_build_OSX_arm64_Debug core.83841 5638848512
redhat.7.amd64.open runtime-libraries-coreclr outerloop libraries_build_Linux_x64_Debug core.1000.11659 133410816
ubuntu.1804.amd64.open runtime-libraries-coreclr outerloop libraries_build_Linux_x64_Debug core.1000.982 141942784

@elinor-fung
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@elinor-fung
Copy link
Member Author

elinor-fung commented Feb 11, 2022

This should mitigate #65000 while re-enabling dumps for real (unexpected) failures.

Verified via Kusto that the dump files for the expected crash are being created as part of tests in 'runtime-libraries-coreclr outerloop' runs now (and not created for the disabled OSX case), while they were in the 'runtime' run before.

The runtime-libraries-coreclr outerloop failures on Linux are unrelated (#58616).

@elinor-fung elinor-fung merged commit 77d6833 into dotnet:main Feb 11, 2022
@elinor-fung elinor-fung deleted the outerloop-expectedCrash branch February 11, 2022 18:22
@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants