Remove % 0 workaround in Microsoft.VisualBasic.CompilerServices

[deeprobin]

Follow up issue for #7141

---

As described in #63902, it would be good to remove comments and workarounds that have already been fixed.

So imo this workaround can be removed:

runtime/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb

Lines 4592 to 4596 in f04a242

	End Function
	<MethodImpl(MethodImplOptions.NoInlining)> ' To work around https://github.com/dotnet/runtime/issues/7141
	Private Shared Function ModSByte(ByVal left As SByte, ByVal right As SByte) As Object
	Return left Mod right

[ghost]

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Follow up issue for #7141

---

As described in #63902, it would be good to remove comments and workarounds that have already been fixed.

So imo this workaround can be removed:

runtime/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb

Lines 4592 to 4596 in f04a242

	End Function
	<MethodImpl(MethodImplOptions.NoInlining)> ' To work around https://github.com/dotnet/runtime/issues/7141
	Private Shared Function ModSByte(ByVal left As SByte, ByVal right As SByte) As Object
	Return left Mod right

Author:	deeprobin
Assignees:	-
Labels:	area-Microsoft.VisualBasic, untriaged
Milestone:	-

[ehasis]

Is jut to remove the line with <MethodImpl(MethodImplOptions.NoInlining)>? If is, then I have the branch ready for pr.

[deeprobin]

That would be nice. Unfortunately, I do not know to what extent such contributions are accepted (see README of MSFT.VB.Core).

We are not accepting feature contributions to Microsoft.VisualBasic.Core. The library is effectively archived.

The library and supporting language features are mature and no longer evolving, and the risk of code change likely exceeds the benefit. We will consider changes that address significant bugs or regressions, or changes that are necessary to continue shipping the binaries. Other changes will be rejected.

[deeprobin]

@ehasis
Removing this seems fine. I think you could create that PR.

[cston]

Closing as per README.md.

@deeprobin, @ehasis, I apologize for not closing earlier.