Cleanup Issue-URLs in Code #63902

deeprobin · 2022-01-17T21:56:59Z

Every now and then issue URLs are written into the code, for example to describe a workaround around a certain bug.

This creates remnants in the code. I have written a small tool, which uses the GitHub API to find all URLs and checks whether this is a closed issue and then exports the whole thing to me as Markdown ¹.

But I am not sure if a certain comment can be removed because the corresponding issue was closed.

I think we should just look at the following code parts and check that.

Find Closed Issues Tool Results (18.01.2022)

Fix the disabled tests in the System V struct passing tests when Issue #2075 is resolved #4680
- The original issue was reopened to address the disabled tests

File src/tests/JIT/Methodical/structs/systemvbringup/structpinvoketests.cs (File Position 3633-3678)

runtime/src/tests/JIT/Methodical/structs/systemvbringup/structpinvoketests.cs

Lines 171 to 175 in f04a242

    
                       public long w; 
        
                   } 
        
           /* These tests are not working on non Windows CoreCLR. Enable this when https://github.com/dotnet/runtime/issues/4680 is resolved. 
        
                   [StructLayout(LayoutKind.Sequential)] 
        
                   public struct S28

[ARM/Linux] paltest_namedmutex_test1 hangs #6014
- Follow-up issue: Review workaround for Named mutex: Use flock instead of pthread process-shared mutex #65929

File src/coreclr/pal/src/include/pal/mutex.hpp (File Position 5384-5430)

runtime/src/coreclr/pal/src/include/pal/mutex.hpp

Lines 122 to 126 in f04a242

    
           // - Temporarily disabling usage of pthread process-shared mutexes on ARM/ARM64 due to functional issues that cannot easily be 
        
           //   detected with code due to hangs. See https://github.com/dotnet/runtime/issues/6014. 
        
           // - On FreeBSD, pthread process-shared robust mutexes cannot be placed in shared memory mapped independently by the processes 
        
           //   involved. See https://github.com/dotnet/runtime/issues/10519.

[RyuJIT] Expression a % 0 sometimes generates incorrect code. #7141
- Follow-up issue: Remove % 0 workaround in Microsoft.VisualBasic.CompilerServices #65230

File src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb (File Position 225458-225503)

runtime/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb

Lines 4592 to 4596 in f04a242

    
           End Function 
        
           <MethodImpl(MethodImplOptions.NoInlining)> ' To work around https://github.com/dotnet/runtime/issues/7141 
        
           Private Shared Function ModSByte(ByVal left As SByte, ByVal right As SByte) As Object 
        
               Return left Mod right

Extra bounds checks are being generated in common span usage pattern #10950
- Follow-up issue: Remove IsEmpty workaround in Span and ReadOnlySpan #64514

File src/libraries/System.Private.CoreLib/src/System/ReadOnlySpan.cs (File Position 6802-6848)

runtime/src/libraries/System.Private.CoreLib/src/System/ReadOnlySpan.cs

Lines 154 to 158 in f04a242

    
           { 
        
               [NonVersionable] 
        
               get => 0 >= (uint)_length; // Workaround for https://github.com/dotnet/runtime/issues/10950 
        
           }

File src/libraries/System.Private.CoreLib/src/System/Span.cs (File Position 7264-7310)

runtime/src/libraries/System.Private.CoreLib/src/System/Span.cs

Lines 159 to 163 in f04a242

    
           { 
        
               [NonVersionable] 
        
               get => 0 >= (uint)_length; // Workaround for https://github.com/dotnet/runtime/issues/10950 
        
           }

Performance Regression: GetCustomAttributes() Allocations Increased from netcoreapp2.1 #11637
- Comment documents reasoning. No follow-up necessary.

File src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs (File Position 59996-60042)

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs

Lines 1329 to 1333 in f04a242

    
           { 
        
               // Resolve method ctor token found in decorated decoratedModule scope 
        
               // See https://github.com/dotnet/runtime/issues/11637 for why we fast-path non-generics here (fewer allocations) 
        
               if (attributeType.IsGenericType) 
        
               {

EnsureValidDataType should reject whitespaces in DataTypeAttribute.CustomDataType property #15690
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs (File Position 3236-3283)

runtime/src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs

Lines 72 to 76 in f04a242

    
               // .NET Core fixed a bug where whitespace strings were allowed as CustomDataType. 
        
               // See https://github.com/dotnet/runtime/issues/15690. 
        
               yield return new object[] { "   ", PlatformDetection.IsNetFramework }; 
        
           }

Add a clean way to cancel a long-running Socket operation (e.g. accept or connect) #16236
- Comment documents reasoning. No follow-up necessary.

File src/mono/mono/utils/mono-threads-windows.c (File Position 4766-4813)

runtime/src/mono/mono/utils/mono-threads-windows.c

Lines 111 to 115 in f04a242

    
           // same resource that was part of the cancelation. Current implementation of 
        
           // .NET Framework and .NET Core currently don't support the ability to abort a thread 
        
           // blocked on sync IO calls, see https://github.com/dotnet/runtime/issues/16236. 
        
           // Since there is no solution covering all scenarios aborting blocking syscall this 
        
           // will be on best effort and there might still be a slight risk that the blocking call

Add IsolatedStorageFile factory methods with Evidence dependencies #18208
- Follow-up issue: Review workaround for IsolatedStorageFile dependency on System.Security.Policy.Evidence #65930

File src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs (File Position 1526-1572)

runtime/src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs

Lines 38 to 42 in f04a242

    
           internal IsolatedStorageFile(IsolatedStorageScope scope) 
        
           { 
        
               // Evidence isn't currently available: https://github.com/dotnet/runtime/issues/18208 
        
               // public static IsolatedStorageFile GetStore(IsolatedStorageScope scope, Evidence domainEvidence, Type domainEvidenceType, Evidence assemblyEvidence, Type assemblyEvidenceType) { return default(IsolatedStorageFile); }

ParameterInfo.HasDefaultValue throws System.FormatException on optional DateTime parameter #18844
- Follow-up issue: Remove ParameterInfo.HasDefaultValue workaround #65233

File src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs (File Position 782-828)

runtime/src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs

Lines 22 to 26 in f04a242

    
           catch (FormatException) when (parameter.ParameterType == typeof(DateTime)) 
        
           { 
        
               // Workaround for https://github.com/dotnet/runtime/issues/18844 
        
               // If HasDefaultValue throws FormatException for DateTime 
        
               // we expect it to have default value

Tuple.IStructuralComparable/Equatable throws NRE #19265
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Runtime/tests/System/TupleTests.cs (File Position 11829-11875)

runtime/src/libraries/System.Runtime/tests/System/TupleTests.cs

Lines 218 to 222 in f04a242

    
           { 
        
               // This was not fixed in order to be compatible with the .NET Framework and Xamarin. 
        
               // See https://github.com/dotnet/runtime/issues/19265 
        
               IStructuralEquatable equatable = (IStructuralEquatable)Tuple; 
        
               Assert.Throws<NullReferenceException>(() => equatable.Equals(Tuple, null));

ValueTuple.IStructuralComparable/Equatable throws NRE instead of ArgumentNullException #19275
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.ValueTuple/tests/ValueTupleTests.cs (File Position 12672-12718)

runtime/src/libraries/System.ValueTuple/tests/ValueTupleTests.cs

Lines 223 to 227 in f04a242

    
           { 
        
               // This was not fixed in order to be compatible with the .NET Framework and Xamarin. 
        
               // https://github.com/dotnet/runtime/issues/19275 
        
               IStructuralEquatable equatable = (IStructuralEquatable)valueTuple; 
        
               if (valueTuple is ValueTuple)

Console.ReadLine() is blocked in Linux even though the StandardInput of the process has been disposed #19277
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs (File Position 18733-18780)

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs

Lines 401 to 405 in f04a242

    
           public void TestEOFReceivedWhenStdInClosed() 
        
           { 
        
               // This is the test for the fix of https://github.com/dotnet/runtime/issues/19277. 
        
               // 
        
               // Summary of the issue:

Vector3GetHashCodeTest AV'ing on Windows release #20080
- Follow-up issue was already open: GT_FIELD of Vector3 has a MACK_Ind context in fgMorphField #7405

File src/tests/JIT/SIMD/Vector3GetHash.cs (File Position 379-425)

runtime/src/tests/JIT/SIMD/Vector3GetHash.cs

Lines 5 to 9 in f04a242

    
           // It exposed a bug in morph, in which a SIMD field was being morphed in 
        
           // a MACK_Ind context, even though it was under a GT_IND(G_ADDR()). 
        
           // This was https://github.com/dotnet/runtime/issues/20080, and was "fixed" with 
        
           // https://github.com/dotnet/coreclr/pull/9496 and a new issue, 
        
           // https://github.com/dotnet/runtime/issues/7405, has been filed to track the underlying unexpected

[Bug Suspected] ImageFormat's "ToString" comparation error #20332
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Drawing.Common/tests/Imaging/ImageFormatTests.cs (File Position 5736-5782)

runtime/src/libraries/System.Drawing.Common/tests/Imaging/ImageFormatTests.cs

Lines 94 to 98 in f04a242

    
           } 
        
           [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Bug fix not in NETFX, https://github.com/dotnet/runtime/issues/20332")] 
        
           [ConditionalTheory(Helpers.IsDrawingSupported)] 
        
           [MemberData(nameof(ImageFromFileToStringTestData))]

System.ServiceProcess.Tests.ServiceBaseTests.TestOnStartThenStop failed in CI #23247
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs (File Position 6751-6797)

runtime/src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs

Lines 145 to 149 in f04a242

    
           { 
        
               // The Service exists at this point, but OpenService is failing, possibly because its being invoked concurrently for another service. 
        
               // https://github.com/dotnet/runtime/issues/23247 
        
               if (svc.Status != ServiceControllerStatus.Stopped) 
        
               {

Unix file enumerator isn't thread safe #24295
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs (File Position 586-633)

runtime/src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs

Lines 14 to 18 in f04a242

    
           // we don't guarantee thread safety of enumerators in general, but on Windows we 
        
           // currently are thread safe, and this test will help ensure that if we change that 
        
           // it's a conscious decision. Discussed in https://github.com/dotnet/runtime/issues/24295. 
        
           [PlatformSpecific(TestPlatforms.Windows)] 
        
           public void FileEnumeratorIsThreadSafe()

Regex fails to accept pattern that it probably should. #24759
- Follow-up issue: Review skipped test case for regex scanner with \c[ pattern #65931

File src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs (File Position 42960-43006)

runtime/src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs

Lines 391 to 395 in f04a242

    
           yield return new object[] { engine, null, @"(cat)(\cz*)(dog)", "asdlkcat\u001adogiwod", RegexOptions.None, new string[] { "cat\u001adog", "cat", "\u001a", "dog" } }; 
        
           if (!PlatformDetection.IsNetFramework) // missing fix for https://github.com/dotnet/runtime/issues/24759 
        
           { 
        
               yield return new object[] { engine, null, @"(cat)(\c[*)(dog)", "asdlkcat\u001bdogiwod", RegexOptions.None, new string[] { "cat\u001bdog", "cat", "\u001b", "dog" } };

System.Configuration.ConfigurationManager SettingElement Null Reference Exception #25369
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs (File Position 1871-1917)

runtime/src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs

Lines 53 to 57 in f04a242

    
           } 
        
           [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, ".NET Framework does not have the fix for https://github.com/dotnet/runtime/issues/25369")] 
        
           [Fact] 
        
           public void DefaultConstructorEqualHashCodes()

BeginConnect_EndPoint_AddressFamily_Throws_NotSupported test fails deterministically on netfx on RS4 #26062
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs (File Position 34725-34771)

runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs

Lines 832 to 836 in f04a242

    
           { 
        
               // Unlike other tests that reuse a static Socket instance, this test avoids doing so 
        
               // to work around a behavior of .NET 4.7.2. See https://github.com/dotnet/runtime/issues/26062 
        
               // for more details.

XmlReader.Create throws IndexOutOfRangeException #28615
- Comment documents reasoning. No follow-up necessary.

File src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs (File Position 342-388)

runtime/src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs

Lines 8 to 12 in f04a242

    
           { 
        
               /// <summary> 
        
               /// This class is not completely testing XmlReader Encoding, it has a regression tests for the fix of the issue: https://github.com/dotnet/runtime/issues/28615 
        
               /// which reported due to fuzzy testing. Defect happening while encoding byte array, which includes a surrogate char and an invalid char. 
        
               /// </summary>

Possible NRE in BinaryFormatterWriter.WriteObject( ... ) method #31402
- The issue was closed as won't-fix
- PR to update the comment: Update stale comments that reference GitHub issues #65932

File src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs (File Position 5028-5074)

runtime/src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs

Lines 118 to 122 in f04a242

    
           int objectId = (int)nameInfo._objectId; 
        
           Debug.Assert(typeNameInfo != null); // Explicitly called with null, asserting for now https://github.com/dotnet/runtime/issues/31402 
        
           string? objectName = objectId < 0 ? 
        
               typeNameInfo.NIname : // Nested Object

Bad IBC data causing official build failures #33303
- Follow-up issue: Review workaround for bad IBC data causing official build failures on macOS #65933

File eng/codeOptimization.targets (File Position 723-769)

runtime/eng/codeOptimization.targets

Lines 8 to 12 in f04a242

    
                      across many of our assemblies on Mac, so disable 
        
                      IBCMerge optimizations on Mac for now to unblock the offical build. 
        
                      See issue https://github.com/dotnet/runtime/issues/33303 
        
                 --> 
        
                 <IsEligibleForNgenOptimization Condition="'$(TargetOS)' == 'OSX' or '$(TargetsMobile)' == 'true'">false</IsEligibleForNgenOptimization>

GCC warns when compiling the JIT: too small to hold all values of regNumber #33541
- Comment documents reasoning. No follow-up necessary.

File src/coreclr/jit/CMakeLists.txt (File Position 388-434)

runtime/src/coreclr/jit/CMakeLists.txt

Lines 7 to 11 in f04a242

    
           # Since there is no better / specific suppression available for these core warnings, we disable 
        
           # warn-as-error (-Werror) for JIT in this case. This issue has been fixed in gcc 11. 
        
           # See https://github.com/dotnet/runtime/issues/33541 
        
           if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11.0) 
        
             add_compile_options(-Wno-error)

CollectionExtensions: Duplicate type in System.Collections and M.E.DependencyModel #34420

Issue was closed as Won't Fix
Comment was already updated when this part of the infrastructure was being refactored

New location/comment:

runtime/src/libraries/testPackages/build/packageTest.targets

Lines 30 to 32 in 331823f

    
             <!-- Type duplicated: https://github.com/dotnet/runtime/issues/34420 --> 
        
             <IgnoredTypes Include="System.Collections.Generic.CollectionExtensions" /> 
        
           </ItemGroup>

File src/libraries/shims/generated/Directory.Build.props (File Position 1110-1156)

runtime/src/libraries/shims/generated/Directory.Build.props

Lines 23 to 27 in f04a242

    
           <ItemGroup> 
        
             <!-- reference everything but self --> 
        
             <!-- Type duplicated in Microsoft.Extensions.DependencyModel. Exclude it for now: https://github.com/dotnet/runtime/issues/34420 --> 
        
             <ReferencePath 
        
               Include="$(NetCoreAppCurrentRefPath)*.dll"

JIT\opt\OSR\tailrecursetry\tailrecursetry.cmd fails with COMPlus_FastTailCalls=0 #35687
- Follow-up issue: Review workaround for TailCallStress mode #65934

File src/tests/JIT/opt/OSR/tailrecursetry.csproj (File Position 260-306)

runtime/src/tests/JIT/opt/OSR/tailrecursetry.csproj

Lines 5 to 9 in f04a242

    
               <Optimize>True</Optimize> 
        
               <!-- This test currently fails for TailcallStress. Disable for JIT stress modes until this is fixed. 
        
                    Issue: https://github.com/dotnet/runtime/issues/35687 
        
               --> 
        
               <JitOptimizationSensitive>true</JitOptimizationSensitive>

Consider adding HalfToInt16Bits and Int16BitsToHalf to BitConverter #38288
- Follow-up issue: Review workaround for HalfToInt16Bits and Int16BitsToHalf in Cbor #65935

File src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/HalfHelpers.cs (File Position 374-420)

runtime/src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/HalfHelpers.cs

Lines 9 to 13 in f04a242

    
           { 
        
               // Temporarily implements missing APIs for System.Half 
        
               // Remove class once https://github.com/dotnet/runtime/issues/38288 has been addressed 
        
               internal static class HalfHelpers 
        
               {

[ARM64] Performance regression: Utf8Encoding #41699
- Original issue was reopened

File src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs (File Position 3321-3367)

runtime/src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs

Lines 63 to 67 in f04a242

    
           char* pEndOfInputBuffer = pInputBuffer + (uint)inputLength; 
        
           // Per https://github.com/dotnet/runtime/issues/41699, temporarily disabling 
        
           // ARM64-intrinsicified code paths. ARM64 platforms may still use the vectorized 
        
           // non-intrinsicified 'else' block below.

System.Diagnostics.Tests.ProcessStandardConsoleTests.TestChangesInConsoleEncoding test fails on server core #42000
- The issue was closed; this scenario has a known issue
- PR to update the comment: Update stale comments that reference GitHub issues #65932

File src/libraries/System.Diagnostics.Process/tests/ProcessStandardConsoleTests.cs (File Position 1362-1408)

runtime/src/libraries/System.Diagnostics.Process/tests/ProcessStandardConsoleTests.cs

Lines 33 to 37 in f04a242

    
           // Don't test this on Windows containers, as the test is currently failing 
        
           // cf. https://github.com/dotnet/runtime/issues/42000 
        
           if (!OperatingSystem.IsWindows() || PlatformDetection.IsInContainer) 
        
           {

Define and implement behavior of tracing functionality when EventSource is disabled via a feature switch #43657
- Follow-up issue: Review workaround for ProcessEvent when event source is disabled #65938

File src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs (File Position 2889-2935)

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs

Lines 40 to 44 in f04a242

    
           { 
        
               // A simple fix to avoid dependencies brought by this method if event source is disabled via a feature switch. 
        
               // Should be reconsidered when https://github.com/dotnet/runtime/issues/43657 is done. 
        
               if (!IsSupported) 
        
               {

Bug in System.IO.Compression.Inflater or the native zlib dependency - invalid distance too far back. #50235
- Follow-up issue: Reconsider tracing functionality when EventSource is disabled #65570

File src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs (File Position 22006-22053)

runtime/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs

Lines 511 to 515 in f04a242

    
           { 
        
               // When running Autobahn Test Suite some tests failed with zlib error "invalid distance too far back". 
        
               // Further investigation lead to a bug fix in zlib intel's implementation - https://github.com/dotnet/runtime/issues/50235. 
        
               // This test replicates one of the Autobahn tests to make sure this issue doesn't appear again. 
        
               byte[][] messages = new[]

Tool source code ↩

The text was updated successfully, but these errors were encountered:

dotnet-issue-labeler · 2022-01-17T21:57:12Z

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

jkotas · 2022-01-17T22:23:07Z

I am not sure if a certain comment can be removed because the corresponding issue was closed.

The issue links are typically used to provide additional context, typically about the corner case that the code is dealing with. It is fine for the linked issue to be closed.

Are you in essence trying to propose an amendment to the coding style with a rule that says "Comments should not contain links to closed issues"? I am not sure whether rule like would an improvement.

ghost · 2022-01-17T22:23:20Z

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Every now and then issue URLs are written into the code, for example to describe a workaround around a certain bug.

This creates remnants in the code. I have written a small tool, which uses the GitHub API to find all URLs and checks whether this is a closed issue and then exports the whole thing to me as Markdown ¹.

But I am not sure if a certain comment can be removed because the corresponding issue was closed.

I think we should just look at the following code parts and check that.

Find Closed Issues Tool Results (17.01.2022)

Issue 882

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/ReadValueTests.cs (Position 27772 - 27816)

Issue 936

References

docs/design/features/arm64-intrinsics.md (Position 14861 - 14905)

Issue 1027

References

eng/pipelines/runtime-official.yml (Position 662 - 707)

Issue 1349

References

src/libraries/System.Text.RegularExpressions/src/README.md (Position 13051 - 13098)

Issue 1423

References

src/libraries/System.Runtime.Caching/src/System/Runtime/Caching/MemoryCacheStatistics.cs (Position 11348 - 11393)

Issue 1780

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/ReferenceHandlerTests.Serialize.cs (Position 4783 - 4828)

Issue 1913

References

src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs (Position 61302 - 61347)

Issue 4069

References

docs/workflow/building/coreclr/freebsd-instructions.md (Position 664 - 712)

Issue 4680

References

src/tests/JIT/Methodical/structs/systemvbringup/structpinvoketests.cs (Position 3633 - 3678)

Issue 4941

References

src/tests/JIT/opt/FastTailCall/StructPassingSimple.cs (Position 392 - 437)

Issue 5552

References

src/tests/Interop/SimpleStruct/SimpleStructManaged.cs (Position 19796 - 19841)

Issue 5778

References

eng/native/configurecompiler.cmake (Position 18571 - 18617)

Issue 5924

References

src/coreclr/pal/tests/palsuite/DisabledTests.txt (Position 1959 - 2004)

Issue 6014

References

src/coreclr/pal/src/include/pal/mutex.hpp (Position 5384 - 5430)

Issue 6775

References

src/tests/JIT/Regression/JitBlue/GitHub_7508/Vector3Test.cs (Position 150 - 195)

Issue 6796

References

src/tests/JIT/Performance/CodeQuality/Inlining/InlineGCStruct.cs (Position 657 - 702)

Issue 6879

References

src/libraries/System.Runtime/tests/System/Runtime/MemoryFailPointTests.cs (Position 989 - 1034)

Issue 7103

References

src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/ArgIterator.cs (Position 13134 - 13179)
src/coreclr/vm/argdestination.h (Position 8755 - 8800)

Issue 7141

References

src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/Operators.vb (Position 225458 - 225503)

Issue 7474

References

src/tests/JIT/Performance/CodeQuality/Layout/SearchLoops.cs (Position 191 - 236)

Issue 7919

References

src/coreclr/gc/env/gcenv.os.h (Position 2508 - 2553)

Issue 8608

References

src/coreclr/nativeaot/Runtime/arm/StubDispatch.S (Position 4834 - 4879)

Issue 8683

References

src/coreclr/jit/lower.cpp (Position 22557 - 22602)

Issue 8730

References

src/libraries/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.il (Position 12818 - 12863)

Issue 8896

References

src/libraries/System.Private.CoreLib/src/System/Buffer.Windows.cs (Position 287 - 332)

Issue 8897

References

src/libraries/System.Private.CoreLib/src/System/Buffer.Unix.cs (Position 425 - 470)

Issue 9014

References

src/libraries/System.Private.CoreLib/src/System/DateTime.Windows.cs (Position 6547 - 6592)

Issue 9401

References

src/tests/JIT/Directed/RVAInit/simplearg.il (Position 188 - 233)

Issue 9495

References

src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128_1.cs (Position 1646 - 1692)
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector256_1.cs (Position 1646 - 1692)
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector64_1.cs (Position 853 - 899)

Issue 9565

References

src/libraries/System.Runtime/tests/System/DateTimeTests.cs (Position 85019 - 85064)

Issue 9635

References

src/tests/JIT/Performance/CodeQuality/Span/SpanBench.cs (Position 16195 - 16240)

Issue 9899

References

src/coreclr/nativeaot/Runtime/amd64/MiscStubs.S (Position 919 - 964)

Issue 10607

References

src/tests/JIT/opt/Structs/structpop.cs (Position 252 - 298)
src/tests/JIT/opt/Structs/structpop2.cs (Position 238 - 284)

Issue 10950

References

src/libraries/System.Private.CoreLib/src/System/ReadOnlySpan.cs (Position 6802 - 6848)
src/libraries/System.Private.CoreLib/src/System/Span.cs (Position 7264 - 7310)

Issue 11191

References

src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs (Position 1012 - 1058)

Issue 11636

References

src/coreclr/pal/tests/palsuite/threading/NamedMutex/test1/namedmutex.cpp (Position 33488 - 33534)

Issue 11637

References

src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs (Position 59996 - 60042)

Issue 11678

References

src/coreclr/vm/stackwalk.cpp (Position 49632 - 49679)

Issue 12392

References

src/tests/JIT/HardwareIntrinsics/X86/Avx1/Avx_r.csproj (Position 146 - 192)
src/tests/JIT/HardwareIntrinsics/X86/Avx2/Avx2_r.csproj (Position 281 - 327)
src/tests/JIT/HardwareIntrinsics/X86/AvxVnni/MultiplyWideningAndAdd_r.csproj (Position 281 - 327)
src/tests/JIT/HardwareIntrinsics/X86/AvxVnni/MultiplyWideningAndAdd_ro.csproj (Position 281 - 327)
src/tests/JIT/HardwareIntrinsics/X86/AvxVnni_Vector128/MultiplyWideningAndAdd_r.csproj (Position 281 - 327)
src/tests/JIT/HardwareIntrinsics/X86/AvxVnni_Vector128/MultiplyWideningAndAdd_ro.csproj (Position 281 - 327)
src/tests/JIT/HardwareIntrinsics/X86/Sse2/Sse2_r.csproj (Position 146 - 192)
src/tests/JIT/HardwareIntrinsics/X86/Sse41/Sse41_r.csproj (Position 146 - 192)

Issue 13382

References

src/libraries/System.Globalization/tests/Invariant/InvariantMode.cs (Position 61998 - 62044)

Issue 13816

References

src/tests/JIT/CodeGenBringUpTests/CastThenBinop.cs (Position 212 - 258)

Issue 14472

References

src/libraries/System.Linq.Parallel/tests/QueryOperators/GroupByTests.cs (Position 6767 - 6813)

Issue 14545

References

src/libraries/System.Runtime.Numerics/tests/BigInteger/parse.cs (Position 678 - 725)

Issue 14654

References

src/libraries/System.Private.Xml/tests/XmlDocument/XmlDocumentTests/LoadTests.cs (Position 270 - 316)

Issue 14793

References

src/libraries/System.Linq.Parallel/tests/Helpers/Comparers.cs (Position 2552 - 2598)
src/libraries/System.Linq.Parallel/tests/QueryOperators/OrderByThenByTests.cs (Position 17667 - 17713)

Issue 14794

References

src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/ImmutableExtensions.Minimal.cs (Position 5362 - 5408)

Issue 14885

References

src/libraries/System.Private.CoreLib/src/System/IO/FileInfo.cs (Position 6056 - 6102)

Issue 15152

References

src/libraries/Directory.Build.props (Position 5457 - 5503)

Issue 15182

References

src/libraries/System.Linq.Expressions/tests/Unary/UnaryIsFalseNullableTests.cs (Position 364 - 410)
src/libraries/System.Linq.Expressions/tests/Unary/UnaryIsFalseTests.cs (Position 391 - 437)
src/libraries/System.Linq.Expressions/tests/Unary/UnaryIsTrueNullableTests.cs (Position 363 - 409)
src/libraries/System.Linq.Expressions/tests/Unary/UnaryIsTrueTests.cs (Position 390 - 436)
src/libraries/System.Linq.Expressions/tests/Unary/UnaryUnaryPlusNullableTests.cs (Position 361 - 407)
src/libraries/System.Linq.Expressions/tests/Unary/UnaryUnaryPlusTests.cs (Position 353 - 399)

Issue 15397

References

src/libraries/System.Linq.Expressions/tests/Unary/UnaryOnesComplementNullableTests.cs (Position 366 - 412)
src/libraries/System.Linq.Expressions/tests/Unary/UnaryOnesComplementTests.cs (Position 419 - 465)

Issue 15650

References

src/libraries/System.Net.Primitives/src/System/Net/HttpStatusCode.cs (Position 1751 - 1798)

Issue 15690

References

src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/DataTypeAttributeTests.cs (Position 3236 - 3283)

Issue 16050

References

src/libraries/System.Drawing.Primitives/tests/PointFTests.cs (Position 5505 - 5552)
src/libraries/System.Drawing.Primitives/tests/RectangleFTests.cs (Position 5865 - 5912)
src/libraries/System.Drawing.Primitives/tests/SizeFTests.cs (Position 4631 - 4678)

Issue 16236

References

src/mono/mono/utils/mono-threads-windows.c (Position 4766 - 4813)

Issue 16737

References

src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpAuthHelper.cs (Position 6698 - 6745)

Issue 17190

References

src/libraries/System.Globalization.Extensions/tests/IdnMapping/IdnMappingGetAsciiTests.cs (Position 757 - 803)
src/libraries/System.Globalization.Extensions/tests/IdnMapping/IdnMappingGetUnicodeTests.cs (Position 6426 - 6472)

Issue 17618

References

src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/Rfc2898DeriveBytes.cs (Position 8410 - 8457)

Issue 18037

References

src/libraries/System.Private.Xml/src/System/Xml/Serialization/ReflectionXmlSerializationWriter.cs (Position 41267 - 41314)

Issue 18208

References

src/libraries/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorageFile.cs (Position 1526 - 1572)

Issue 18254

References

src/libraries/System.Security.Cryptography.Pkcs/tests/Pkcs12/Pkcs12Documents.cs (Position 609 - 655)

Issue 18664

References

src/libraries/System.Runtime.Extensions/tests/System/IO/PathTests_Windows.cs (Position 11327 - 11373)

Issue 18676

References

src/libraries/System.Linq.Expressions/tests/CompilerTests.cs (Position 5022 - 5068)

Issue 18844

References

src/libraries/Common/src/Extensions/ParameterDefaultValue/ParameterDefaultValue.netstandard.cs (Position 782 - 828)

Issue 19106

References

src/libraries/System.Linq.Expressions/tests/Lifted/LiftedAddCheckedNullableTests.cs (Position 7338 - 7384)

Issue 19265

References

src/libraries/System.Runtime/tests/System/TupleTests.cs (Position 11829 - 11875)

Issue 19275

References

src/libraries/System.ValueTuple/tests/ValueTupleTests.cs (Position 12672 - 12718)

Issue 19277

References

src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs (Position 18733 - 18780)

Issue 19584

References

src/libraries/Directory.Build.targets (Position 5459 - 5505)

Issue 20080

References

src/tests/JIT/SIMD/Vector3GetHash.cs (Position 379 - 425)

Issue 20097

References

src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs (Position 45153 - 45199)

Issue 20232

References

src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactory.CreatePermission.cs (Position 297 - 343)

Issue 20332

References

src/libraries/System.Drawing.Common/tests/Imaging/ImageFormatTests.cs (Position 5736 - 5782)

Issue 20728

References

src/libraries/System.IO.Ports/tests/SerialPort/AbortOnError.cs (Position 417 - 463)

Issue 20884

References

src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/PhoneAttributeTests.cs (Position 2662 - 2709)

Issue 21100

References

src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/CustomValidationAttributeTests.cs (Position 7497 - 7544)

Issue 21101

References

src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/MaxLengthAttributeTests.cs (Position 4331 - 4377)
src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/MinLengthAttributeTests.cs (Position 3773 - 3819)

Issue 21236

References

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/AesContractTests.cs (Position 2251 - 2297)

Issue 21257

References

src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/EdgeCasesTests.cs (Position 6546 - 6592)

Issue 21354

References

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/AES/DecryptorReusability.cs (Position 414 - 460)

Issue 21421

References

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestNegative.cs (Position 2296 - 2342)

Issue 21673

References

src/libraries/System.IO.FileSystem/tests/Directory/Move.cs (Position 2031 - 2077)

Issue 21742

References

src/libraries/System.IO.IsolatedStorage/tests/System/IO/IsolatedStorage/HelperTests.cs (Position 1585 - 1631)

Issue 21745

References

src/libraries/System.IO.FileSystem/tests/FileInfo/Length.cs (Position 1694 - 1740)

Issue 21860

References

src/tests/JIT/Directed/StructPromote/Unsafe/AccessInvalidFieldOffset.cs (Position 163 - 210)
src/tests/JIT/Directed/StructPromote/Unsafe/ReadDoubleFromIntOffset.cs (Position 163 - 210)
src/tests/JIT/Directed/StructPromote/Unsafe/ReadStructAsAnotherType.cs (Position 163 - 210)

Issue 22093

References

src/libraries/System.Collections.Immutable/tests/ImmutableListBuilderTest.cs (Position 7514 - 7561)

Issue 23104

References

src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs (Position 57776 - 57822)

Issue 23198

References

src/libraries/System.Private.CoreLib/src/System/Random.Net5CompatImpl.cs (Position 8072 - 8118)

Issue 23247

References

src/libraries/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs (Position 6751 - 6797)

Issue 23380

References

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestEventCounter.cs (Position 1184 - 1230)

Issue 23389

References

src/libraries/System.Linq/tests/ConcatTests.cs (Position 20543 - 20589)

Issue 23525

References

src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs (Position 5962 - 6008)

Issue 23646

References

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs (Position 12559 - 12605)

Issue 23776

References

src/libraries/System.Console/src/System/ConsolePal.Windows.cs (Position 55081 - 55127)

Issue 24237

References

src/libraries/System.ComponentModel.Annotations/tests/System/ComponentModel/DataAnnotations/ValidatorTests.cs (Position 9382 - 9428)

Issue 24295

References

src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs (Position 586 - 633)

Issue 24407

References

src/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEBuilderTests.cs (Position 6623 - 6670)

Issue 24759

References

src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs (Position 42960 - 43006)

Issue 24898

References

src/libraries/Common/tests/Tests/System/IO/PathInternal.Unix.Tests.cs (Position 1703 - 1749)

Issue 24948

References

src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/Encoding/MethodBodyStreamEncoder.cs (Position 9935 - 9982)

Issue 25086

References

src/libraries/Common/tests/System/Net/Http/PostScenarioTest.cs (Position 13192 - 13239)

Issue 25177

References

src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/AssemblyCatalog.cs (Position 25368 - 25414)

Issue 25195

References

src/libraries/System.Formats.Asn1/tests/Reader/ReadT61String.cs (Position 447 - 493)
src/libraries/System.Security.Cryptography.X509Certificates/tests/X500DistinguishedNameTests.cs (Position 17438 - 17484)

Issue 25369

References

src/libraries/System.Configuration.ConfigurationManager/tests/System/Configuration/SettingElementTests.cs (Position 1871 - 1917)

Issue 25643

References

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Authentication.cs (Position 2330 - 2376)

Issue 25778

References

src/libraries/Microsoft.Win32.Registry/tests/Registry/Registry_SetValue_str_str_obj.cs (Position 5567 - 5613)
src/libraries/Microsoft.Win32.Registry/tests/RegistryKey/RegistryKey_SetValue_str_obj.cs (Position 4977 - 5023)

Issue 26062

References

src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs (Position 34725 - 34771)

Issue 26197

References

src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/FuzzyTests.cs (Position 747 - 793)
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsUserErrors.cs (Position 2423 - 2469)
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsUserErrors.Etw.cs (Position 613 - 659)
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWrite.Etw.cs (Position 725 - 771)
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWriteEvent.Etw.cs (Position 712 - 758)

Issue 26286

References

src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs (Position 3021 - 3067)

Issue 27221

References

src/native/libs/System.Native/pal_networking.c (Position 45284 - 45330)

Issue 27919

References

src/libraries/System.Text.Json/src/System/Text/Json/Reader/JsonReaderHelper.Unescaping.cs (Position 1651 - 1697)
src/libraries/System.Text.Json/src/System/Text/Json/Writer/JsonWriterHelper.Escaping.cs (Position 438 - 484)

Issue 28403

References

src/libraries/System.Diagnostics.EventLog/tests/System/Diagnostics/Reader/EventLogRecordTests.cs (Position 1273 - 1319)

Issue 28615

References

src/libraries/System.Private.Xml/tests/XmlReader/Tests/ReaderEncodingTests.cs (Position 342 - 388)

Issue 28740

References

src/libraries/System.Net.Primitives/tests/FunctionalTests/IPAddressTest.cs (Position 8831 - 8877)

Issue 29019

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Array.ReadTests.cs (Position 3567 - 3613)

Issue 29021

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.ReadTests.cs (Position 5009 - 5055)

Issue 29123

References

src/libraries/System.Linq.Parallel/tests/Combinatorial/ParallelQueryCombinationTests.cs (Position 480 - 526)

Issue 29204

References

src/installer/tests/TestUtils/FileUtils.cs (Position 1397 - 1443)

Issue 29293

References

src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteProperties.String.cs (Position 61458 - 61504)
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Bytes.cs (Position 1670 - 1716)
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.String.cs (Position 3985 - 4031)

Issue 29503

References

src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs (Position 44604 - 44650)

Issue 29504

References

src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Dictionary.cs (Position 17997 - 18043)

Issue 29743

References

src/libraries/System.Text.Json/docs/ParameterizedCtorSpec.md (Position 1635 - 1682)

Issue 29894

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/ReadScenarioTests.cs (Position 577 - 624)

Issue 29969

References

src/libraries/System.Data.OleDb/tests/Helpers.cs (Position 2115 - 2161)

Issue 30095

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonReaderTests.TryGet.Date.cs (Position 6234 - 6280)

Issue 30132

References

src/libraries/System.Globalization/tests/System/Globalization/RegionInfoTests.cs (Position 4336 - 4382)

Issue 30135

References

src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.Date.cs (Position 23428 - 23475)

Issue 30187

References

src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs (Position 107645 - 107691)

Issue 30440

References

src/libraries/System.Collections/tests/BitArray/BitArray_GetSetTests.cs (Position 18107 - 18153)

Issue 30524

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/NewtonsoftTests/ImmutableCollectionsTests.cs (Position 9588 - 9634)

Issue 30686

References

src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.ObjectModel.Read.cs (Position 685 - 732)

Issue 30732

References

src/libraries/System.Net.Mail/src/System/Net/Mail/SmtpConnection.cs (Position 6060 - 6106)

Issue 30746

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.cs (Position 136992 - 137038)

Issue 30814

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.WriteTests.cs (Position 4550 - 4596)

Issue 31402

References

src/libraries/System.Runtime.Serialization.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs (Position 5028 - 5074)

Issue 31483

References

src/libraries/Common/tests/System/RealFormatterTestsBase.cs (Position 624 - 670)

Issue 32377

References

src/mono/mono/utils/mono-threads-posix.c (Position 5672 - 5718)

Issue 33303

References

eng/codeOptimization.targets (Position 723 - 769)

Issue 33541

References

src/coreclr/jit/CMakeLists.txt (Position 388 - 434)

Issue 33989

References

src/libraries/Microsoft.Extensions.Configuration.UserSecrets/tests/MsBuildTargetTest.cs (Position 1398 - 1444)

Issue 33998

References

src/libraries/testPackages/build/packageTest.targets (Position 1572 - 1618)

Issue 34091

References

src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerFactoryExtensionsTest.cs (Position 353 - 399)
src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerTest.cs (Position 5992 - 6038)

Issue 34420

References

src/libraries/shims/generated/Directory.Build.props (Position 1110 - 1156)

Issue 34442

References

src/libraries/System.DirectoryServices/tests/System/DirectoryServices/ActiveDirectory/DomainControllerTests.cs (Position 2173 - 2219)
src/libraries/System.DirectoryServices/tests/System/DirectoryServices/ActiveDirectory/ForestTests.cs (Position 1644 - 1690)
src/libraries/System.DirectoryServices/tests/System/DirectoryServices/DirectoryEntryTests.cs (Position 5806 - 5852)
src/libraries/System.DirectoryServices.AccountManagement/tests/ComputerPrincipalTest.cs (Position 2100 - 2146)
src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalContextTests.cs (Position 516 - 562)

Issue 34490

References

src/libraries/System.IO.Ports/tests/SerialPort/GetPortNames.cs (Position 740 - 786)

Issue 34493

References

src/libraries/System.Reflection.Metadata/tests/Utilities/AbstractMemoryBlockTests.cs (Position 5499 - 5545)

Issue 34502

References

src/libraries/System.Threading.Overlapped/tests/ThreadPoolBoundHandle_AllocateNativeOverlappedTests.cs (Position 250 - 296)

Issue 34583

References

src/libraries/System.IO/tests/StreamReader/StreamReaderTests.cs (Position 16288 - 16334)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.cs (Position 300 - 346)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs (Position 244 - 290)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs (Position 240 - 286)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs (Position 265 - 311)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs (Position 287 - 333)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs (Position 279 - 325)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs (Position 244 - 290)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs (Position 296 - 342)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs (Position 265 - 311)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs (Position 260 - 306)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs (Position 335 - 381)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs (Position 230 - 276)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs (Position 205 - 251)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs (Position 392 - 438)
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.WaitForChanged.cs (Position 236 - 282)
src/libraries/System.IO.Pipes.AccessControl/tests/AssemblyInfo.cs (Position 181 - 227)

Issue 34689

References

src/libraries/System.Management/tests/System/Management/ManagementClassTests.cs (Position 409 - 455)
src/libraries/System.Management/tests/System/Management/ManagementClassTestsMofRequired.cs (Position 408 - 454)
src/libraries/System.Management/tests/System/Management/ManagementObjectSearcherTests.cs (Position 380 - 426)
src/libraries/System.Management/tests/System/Management/ManagementObjectTests.cs (Position 969 - 1015)
src/libraries/System.Management/tests/System/Management/SelectQueryTests.cs (Position 373 - 419)

Issue 34962

References

src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializerStressTests.cs (Position 331 - 377)

Issue 35687

References

src/tests/JIT/opt/OSR/tailrecursetry.csproj (Position 260 - 306)

Issue 36028

References

src/tests/tracing/eventpipe/eventsourceerror/eventsourceerror.csproj (Position 218 - 264)

Issue 37064

References

src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEngine.Unix.cs (Position 13279 - 13325)

Issue 37237

References

src/tests/Interop/PInvoke/IEnumerator/IEnumeratorTest.csproj (Position 188 - 234)

Issue 38288

References

src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/HalfHelpers.cs (Position 374 - 420)

Issue 38507

References

src/tests/JIT/opt/Inline/regression/badcallee/badcallee.ilproj (Position 216 - 262)

Issue 38524

References

src/tests/tracing/eventpipe/diagnosticport/diagnosticport.csproj (Position 388 - 434)
src/tests/tracing/eventpipe/pauseonstart/pauseonstart.csproj (Position 388 - 434)
src/tests/tracing/eventpipe/reverse/reverse.csproj (Position 388 - 434)

Issue 38559

References

src/libraries/System.Net.Security/tests/UnitTests/SslAuthenticationOptionsTests.cs (Position 3738 - 3784)

Issue 38639

References

src/tests/tracing/eventpipe/gcdump/gcdump.cs (Position 652 - 698)

Issue 38943

References

src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs (Position 8639 - 8685)

Issue 39285

References

src/libraries/System.Globalization.Calendars/tests/TaiwanCalendar/TaiwanCalendarDaysAndMonths.cs (Position 328 - 374)

Issue 39390

References

src/libraries/System.Text.RegularExpressions/tests/Regex.Match.Tests.cs (Position 1690 - 1736)

Issue 39584

References

src/tests/Interop/COM/Dynamic/Dynamic.csproj (Position 435 - 481)

Issue 39650

References

src/libraries/System.Reflection/tests/CoreCLR/AssemblyTests.cs (Position 320 - 366)

Issue 39935

References

src/tests/tracing/eventpipe/processinfo/processinfo.csproj (Position 443 - 489)
src/tests/tracing/eventpipe/processinfo2/processinfo2.csproj (Position 443 - 489)

Issue 40190

References

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/CounterGroup.cs (Position 9259 - 9305)

Issue 40412

References

src/libraries/System.IO.FileSystem.Watcher/src/System/IO/FileSystemWatcher.Win32.cs (Position 12357 - 12405)

Issue 41699

References

src/libraries/System.Private.CoreLib/src/System/Text/Unicode/Utf16Utility.Validation.cs (Position 3321 - 3367)

Issue 42000

References

src/libraries/System.Diagnostics.Process/tests/ProcessStandardConsoleTests.cs (Position 1362 - 1408)

Issue 42070

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/ContinuationTests.NullToken.cs (Position 369 - 415)

Issue 42207

References

src/libraries/System.Runtime.Loader/tests/LoaderLinkTest.cs (Position 403 - 449)

Issue 43166

References

src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs (Position 7506 - 7553)

Issue 43207

References

src/libraries/System.ServiceProcess.ServiceController/tests/ServiceBaseTests.cs (Position 6880 - 6926)

Issue 43411

References

src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.External.Tests/AssemblyInfo.cs (Position 196 - 242)

Issue 43657

References

src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/NativeRuntimeEventSource.cs (Position 2889 - 2935)

Issue 43751

References

src/libraries/System.Net.WebSockets.Client/tests/ClientWebSocketOptionsTests.cs (Position 1891 - 1937)

Issue 44288

References

src/libraries/System.Data.OleDb/src/OleDbConnectionInternal.cs (Position 15809 - 15856)

Issue 44605

References

src/libraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.cs (Position 19234 - 19280)

Issue 44681

References

src/libraries/System.Collections/tests/Generic/Dictionary/Dictionary.Tests.cs (Position 14125 - 14171)

Issue 44767

References

src/libraries/Microsoft.Extensions.FileSystemGlobbing/tests/FunctionalTests.cs (Position 41641 - 41687)

Issue 44768

References

src/libraries/System.Private.Xml/tests/TrimmingTests/XmlSerializer.Deserialize.cs (Position 458 - 504)
src/libraries/System.Private.Xml/tests/TrimmingTests/XmlSerializer.Deserialize.SealerOpt.cs (Position 574 - 620)
src/libraries/System.Private.Xml/tests/TrimmingTests/XmlSerializer.Serialize.cs (Position 438 - 484)

Issue 44876

References

src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs (Position 67690 - 67737)

Issue 45464

References

src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Cache.cs (Position 5659 - 5705)
src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Stream.cs (Position 394 - 440)
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/JsonDocumentTests.cs (Position 19852 - 19898)
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Stream.WriteTests.cs (Position 2317 - 2363)
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonReaderTests.MultiSegment.cs (Position 91019 - 91065)

Issue 45557

References

src/tests/JIT/Regression/JitBlue/Runtime_45557/Runtime_45557.cs (Position 164 - 210)

Issue 46279

References

src/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.csproj (Position 158 - 204)

Issue 46520

References

src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Dictionary.NonStringKey.cs (Position 32085 - 32131)

Issue 46983

References

src/libraries/System.Net.WebSockets.Client/tests/SendReceiveTest.cs (Position 4886 - 4932)

Issue 47112

References

src/tests/FunctionalTests/iOS/Simulator/LambdaCompilerAOT/Program.cs (Position 541 - 587)

Issue 47378

References

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs (Position 5627 - 5673)
src/libraries/System.Net.Security/tests/FunctionalTests/ClientAsyncAuthenticateTest.cs (Position 6686 - 6732)
src/libraries/System.Net.Security/tests/FunctionalTests/ServerAsyncAuthenticateTest.cs (Position 19073 - 19119)

Issue 47943

References

src/coreclr/jit/emitxarch.cpp (Position 22736 - 22783)
src/coreclr/jit/instrsxarch.h (Position 17612 - 17658)

Issue 48416

References

docs/design/mono/mobile-runtimeconfig-json.md (Position 1045 - 1091)

Issue 49078

References

src/tests/JIT/Regression/JitBlue/Runtime_49078/Runtime_49078.cs (Position 204 - 250)

Issue 49111

References

src/libraries/System.Drawing.Common/tests/GdiplusTests.cs (Position 339 - 385)

Issue 49871

References

src/libraries/System.Security.Cryptography.Xml/tests/EncryptedXmlTests.cs (Position 400 - 446)

Issue 49985

References

src/tests/Regressions/coreclr/GitHub_49826/test49826.csproj (Position 249 - 295)

Issue 50235

References

src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs (Position 22006 - 22053)

Issue 50397

References

src/libraries/Microsoft.Extensions.Hosting/docs/HostShutdown.md (Position 2380 - 2426)

Issue 50492

References

src/tests/JIT/opt/Devirtualization/GitHub_50492.cs (Position 697 - 743)

Issue 50515

References

src/tests/tracing/eventpipe/bigevent/bigevent.cs (Position 1311 - 1357)

Issue 50570

References

src/libraries/System.Diagnostics.Debug/tests/DebugTestsUsingListeners.cs (Position 8458 - 8504)

Issue 50571

References

src/libraries/System.Net.Primitives/tests/FunctionalTests/LoggingTest.cs (Position 425 - 471)

Issue 50721

References

src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Generic.Read.cs (Position 24841 - 24887)
src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.Generic.Write.cs (Position 13908 - 13954)

Issue 50854

References

eng/pipelines/libraries/stress/http.yml (Position 4303 - 4349)

Issue 50881

References

src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/InvalidAsynchronousStateExceptionTests.cs (Position 1752 - 1798)

Issue 50935

References

src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs (Position 10350 - 10396)

Issue 51133

References

src/tests/tracing/eventpipe/bigevent/bigevent.csproj (Position 364 - 410)

Issue 51159

References

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs (Position 6698 - 6745)

Issue 51331

References

src/libraries/System.Security.Cryptography.Csp/tests/DSACryptoServiceProviderTests.cs (Position 1201 - 1247)

Issue 51332

References

src/libraries/System.Security.Cryptography/tests/AesCcmTests.cs (Position 450 - 496)
src/libraries/System.Security.Cryptography/tests/AesGcmTests.cs (Position 450 - 496)

Issue 51370

References

src/libraries/System.Security.Cryptography.Xml/tests/Samples/SigningVerifyingX509Cert.cs (Position 2323 - 2369)

Issue 51837

References

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/ReferenceHandlerTests.IgnoreCycles.cs (Position 15801 - 15847)

Issue 51949

References

src/libraries/System.Linq.Expressions/tests/Call/CallTests.cs (Position 11506 - 11552)

Issue 53321

References

src/tests/JIT/superpmi/superpmicollect.csproj (Position 715 - 761)

Issue 53367

References

src/mono/wasm/build/WasmApp.Native.targets (Position 5802 - 5848)

Issue 53432

References

src/libraries/System.IO.FileSystem/tests/File/OpenHandle.cs (Position 1603 - 1649)

Issue 53599

References

src/libraries/System.Linq.Expressions/tests/InterpreterTests.cs (Position 4457 - 4503)

Issue 54469

References

src/coreclr/utilcode/loaderheap.cpp (Position 71333 - 71379)

Issue 56267

References

src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs (Position 190861 - 190907)

Issue 56922

References

src/libraries/System.IO.FileSystem/tests/Directory/Delete.Windows.cs (Position 536 - 582)

Issue 57360

References

src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.AsyncEnumerable.cs (Position 11791 - 11837)

Issue 59255

References

src/tests/BuildWasmApps/Wasm.Build.Tests/BlazorWasmBuildPublishTests.cs (Position 7737 - 7783)

Issue 60133

References

src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicConnection.cs (Position 12942 - 12988)

Issue 60480

References

src/libraries/System.Drawing.Common/tests/PenTests.cs (Position 1773 - 1819)

Issue 62079

References

src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs (Position 4367 - 4413)

Issue 63610

References

src/tests/JIT/Regression/JitBlue/Runtime_63610/Runtime_63610.cs (Position 916 - 962)

Author:	deeprobin
Assignees:	-
Labels:	`area-Meta`, `untriaged`
Milestone:	-

I can make the tool available under an open source license if desired. ↩

MichalStrehovsky · 2022-01-17T23:13:55Z

I think it would be useful if you could update the tool to also show an excerpt from the source file.

Code with comments like "we have to do this workaround until #1234567 is fixed" where 1234567 is closed might need attention. Comments like "this fixes the issue described in #1234567" are fine and provide useful context.

deeprobin · 2022-01-18T20:49:46Z

No I am not trying to propose that you remove all issue comments in general. My main point was that there are many comments that rather describe a workaround of an issue. In the meantime, the issue may have been closed.

deeprobin · 2022-01-18T20:52:37Z

I think it would be useful if you could update the tool to also show an excerpt from the source file.

Code with comments like "we have to do this workaround until #1234567 is fixed" where 1234567 is closed might need attention. Comments like "this fixes the issue described in #1234567" are fine and provide useful context.

I have adjusted that accordingly.
The current results are now in the top post.

Now I filter by specific keywords using contains:

[ActiveIssue(
fix
resolve
workaround
work around
for now
temporarily
currently

deeprobin · 2022-01-18T21:00:30Z

I have pushed my current source code to a GitHub repo.

Note that this is not pretty code and I wrote the program very fast and sloppy.

If I have enough time I can refactor the tool accordingly.

Current procedure

Set GitHub API Key (we need this because the unauthorized api has low rate limits)

https://github.com/deeprobin/dotnet-issue-finder/blob/e59e82f544f8e687edce7954b94100e2987d883a/src/main.rs#L19

Set path to the local copy of your runtime

danmoseley · 2022-01-18T21:00:51Z

You can remove the several that refer to .NET Framework -- we treat the .NET Framework behaviors as "fixed" so if we're working around something in it, we will forever. The issue number explains why.

ghost · 2022-01-21T00:36:23Z

This issue has been marked needs-author-action since it may be missing important information. Please refer to our contribution guidelines for tips on how to report issues effectively.

ericstj · 2022-01-21T00:47:02Z

I took a look at a few, some are interesting, some are intentional. IMO this needs some human supervision on the tool. I've added check-boxes to your report. I suggest that folks collaborate on assessing them. For each one consider the following:

Reactivate the issue and add a comment to clean up the code. If the issue is very old, then perhaps a new issue (or just PR it and refer to this issue)
Accept the comment as valuable (ideally you could then ignore the tool report).

deeprobin · 2022-01-21T08:44:28Z

@ericstj
Super. Thank you very much.

Unfortunately, I can't comment on or reactivate the closed issues, as most of them are marked as "locked".

jeffhandley · 2022-01-22T04:41:22Z

I can't comment on or reactivate the closed issues, as most of them are marked as "locked".

@deeprobin I was about to start unlocking them, but I think it would be better to just file new issues. That will ensure the issues are routed to the current area owners.

If you would like to open the new issues for each of the remaining instances, please go ahead and do so. Or let us know if you need us to open the issues on your behalf. Thanks for taking this initiative!

ghost · 2022-02-03T11:14:47Z

This issue has been marked needs-author-action since it may be missing important information. Please refer to our contribution guidelines for tips on how to report issues effectively.

deeprobin · 2022-02-18T15:55:33Z

@jeffhandley

I can't comment on or reactivate the closed issues, as most of them are marked as "locked".

@deeprobin I was about to start unlocking them, but I think it would be better to just file new issues. That will ensure the issues are routed to the current area owners.

I've already opened a few issues and accordingly marked the item at the top of the listing with the appropriate follow up issue and marked it as done in our list.

If you would like to open the new issues for each of the remaining instances, please go ahead and do so. Or let us know if you need us to open the issues on your behalf. Thanks for taking this initiative!

However, this is also not done in 2 minutes, so I don't mind support in opening Issues on my behalf.
Might be a useful sideline when waiting for all CI pipelines to pass.

Afterwards, we should consider whether such a process should be carried out every few months, as certain issues are likely to be closed in the meantime.

jeffhandley · 2022-02-27T23:52:17Z

All of the identified cases have been fielded and the issue description is updated to reflect the status for each instance. Several follow-up issues were filed, a couple issues were reopened, and a few comments are being updated in #65932.

Thanks for generating this report and iterating on it to help make it addressable, @deeprobin. We would welcome having this report produced every few months or so if you'd like to do that. And the single issue formatted as we landed here ended up being effective.

deeprobin · 2022-02-28T05:39:11Z

Thanks @jeffhandley,
for taking care of this.

I would think it would be useful to set up a GitHub workflow of the schedule type for this, which would run this tool every 3 months, for example.
If necessary we could merge this into the runtime repo or alternatively rewrite the tool in C# (which at best also creates the issues automatically).

I'll also look at writing a GitHub Action soon to see if that would be useful.

jeffhandley · 2022-02-28T06:12:24Z

Before we pursue automating it, I think it would be best to conduct a couple more manual runs to assess the reoccurring value. Some of the issues found this round were years old and it's unclear to me how frequently we're accruing new "debt."

dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 17, 2022

jkotas added the area-Meta label Jan 17, 2022

ghost added this to Needs triage in Triage POD for Meta, Reflection, etc Jan 17, 2022

stephentoub added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 18, 2022

jkotas removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 18, 2022

ericstj added needs-author-action An issue or pull request that requires more info or actions from the author. question Answer questions and provide assistance, not an issue with source code or documentation. and removed untriaged New issue has not been triaged by the area owner labels Jan 21, 2022

ghost added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Jan 21, 2022

jeffhandley removed the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Jan 22, 2022

This was referenced Jan 30, 2022

Remove CheckForOverflowUnderflow #63725

Closed

Remove IsEmpty workaround in Span and ReadOnlySpan #64514

Closed

jeffhandley added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 3, 2022

This was referenced Feb 11, 2022

Remove % 0 workaround in Microsoft.VisualBasic.CompilerServices #65230

Closed

Remove ParameterInfo.HasDefaultValue workaround #65233

Closed

ghost added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Feb 18, 2022

deeprobin mentioned this issue Feb 18, 2022

Reconsider tracing functionality when EventSource is disabled #65570

Open

jeffhandley closed this as completed Feb 27, 2022

Triage POD for Meta, Reflection, etc automation moved this from Needs triage to Done Feb 27, 2022

deeprobin mentioned this issue Mar 9, 2022

Fix DNS cancellation deadlock #63904

Merged

dotnet locked as resolved and limited conversation to collaborators Mar 30, 2022

Cleanup Issue-URLs in Code #63902

Cleanup Issue-URLs in Code #63902

Comments

deeprobin commented Jan 17, 2022 • edited by jeffhandley

Find Closed Issues Tool Results (18.01.2022)

Footnotes

dotnet-issue-labeler bot commented Jan 17, 2022

jkotas commented Jan 17, 2022

ghost commented Jan 17, 2022

Find Closed Issues Tool Results (17.01.2022)

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

References

deeprobin commented Jan 17, 2022 •

edited by jeffhandley