Invalid type for MakeGenericMethod is crashing the runtime #71339
Comments
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsOne of the types from the test below is crashing the mono runtime in #71324 (most likely Specific commit affected Relevant code: [Theory]
[InlineData(typeof(void))]
[InlineData(typeof(Dictionary<,>))]
[InlineData(typeof(List<>))]
[InlineData(typeof(Nullable<>))]
[InlineData(typeof(int*))]
[InlineData(typeof(RefStruct))]
public static void CreateJsonTypeInfoWithInappropriateTypeThrows(Type type)
{
Assert.Throws<ArgumentException>(() => JsonTypeInfo.CreateJsonTypeInfo(type, new JsonSerializerOptions()));
}
// JsonTypeInfo.CreateJsonTypeInfo:
if (IsInvalidForSerialization(type)) // it seems it passed the check in the repro
{
ThrowHelper.ThrowArgumentException_CannotSerializeInvalidType(nameof(type), type, null, null);
}
s_createJsonTypeInfo ??= typeof(JsonTypeInfo).GetMethod(nameof(CreateJsonTypeInfo), new Type[] { typeof(JsonSerializerOptions) })!;
return (JsonTypeInfo)s_createJsonTypeInfo.MakeGenericMethod(type)
.Invoke(null, new object[] { options })!;
|
krwq
changed the title
krwq
added a commit
to krwq/runtime-1
that referenced
this issue
Jun 27, 2022
|
Here is the full log |
krwq
added a commit
that referenced
this issue
Jun 27, 2022
) * Argument tests for CreateJsonTypeInfo and CreateJsonPropertyInfo * add check for typeof(void) - possibly workaround #71339
|
It seems like it might be possible to isolate this in a standalone reproduction that doesn't use json components? |
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsOne of the types from the test below is crashing the mono runtime in #71324 (most likely Specific commit affected Relevant code: [Theory]
[InlineData(typeof(void))]
[InlineData(typeof(Dictionary<,>))]
[InlineData(typeof(List<>))]
[InlineData(typeof(Nullable<>))]
[InlineData(typeof(int*))]
[InlineData(typeof(RefStruct))]
public static void CreateJsonTypeInfoWithInappropriateTypeThrows(Type type)
{
Assert.Throws<ArgumentException>(() => JsonTypeInfo.CreateJsonTypeInfo(type, new JsonSerializerOptions()));
}
// JsonTypeInfo.CreateJsonTypeInfo:
if (IsInvalidForSerialization(type)) // it seems it passed the check in the repro
{
ThrowHelper.ThrowArgumentException_CannotSerializeInvalidType(nameof(type), type, null, null);
}
s_createJsonTypeInfo ??= typeof(JsonTypeInfo).GetMethod(nameof(CreateJsonTypeInfo), new Type[] { typeof(JsonSerializerOptions) })!;
return (JsonTypeInfo)s_createJsonTypeInfo.MakeGenericMethod(type)
.Invoke(null, new object[] { options })!;
|
|
|
marek-safar
added
area-VM-reflection-mono
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One of the types from the test below is crashing the mono runtime in #71324 (most likely
typeof(void))Specific commit affected
39b0578
Relevant code:
cc: @steveisok @fanyang-mono
The text was updated successfully, but these errors were encountered: