Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] System.Net.Http.Functional.Tests*EventSource_ExistsWithCorrectId failing on browser #71877

Open
radical opened this issue Jul 9, 2022 · 4 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Net.Http disabled-test The test is disabled in source code against the issue os-browser Browser variant of arch-wasm
Milestone

Comments

@radical
Copy link
Member

radical commented Jul 9, 2022

The bump to emsdk 3.1.12 - #70693 also switches the windows library tests to run on Chrome, instead of V8. And this causes some more tests to be run.

System.Net.Http.Functional.Tests*EventSource_ExistsWithCorrectId are failing:

public void EventSource_ExistsWithCorrectId()
{
Type esType = typeof(HttpClient).Assembly.GetType("System.Net.NetEventSource", throwOnError: true, ignoreCase: false);
Assert.NotNull(esType);
Assert.Equal("Private.InternalDiagnostics.System.Net.Http", EventSource.GetName(esType));

[FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_DiagnosticsTest_Http2.EventSource_ExistsWithCorrectId
Assert.Equal() Failure
          ↓ (pos 0)
Expected: Private.InternalDiagnostics.System.Net.Ht···
Actual:   NetEventSource
          ↑ (pos 0)
   at System.Net.Http.Functional.Tests.DiagnosticsTest.EventSource_ExistsWithCorrectId()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )

[FAIL] System.Net.Http.Functional.Tests.SyncHttpHandler_DiagnosticsTest.EventSource_ExistsWithCorrectId
Assert.Equal() Failure
          ↓ (pos 0)
Expected: Private.InternalDiagnostics.System.Net.Ht···
Actual:   NetEventSource
          ↑ (pos 0)
   at System.Net.Http.Functional.Tests.DiagnosticsTest.EventSource_ExistsWithCorrectId()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )

[FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_DiagnosticsTest_Http11.EventSource_ExistsWithCorrectId
Assert.Equal() Failure
          ↓ (pos 0)
Expected: Private.InternalDiagnostics.System.Net.Ht···
Actual:   NetEventSource
          ↑ (pos 0)
   at System.Net.Http.Functional.Tests.DiagnosticsTest.EventSource_ExistsWithCorrectId()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )

cc @lambdageek @pavelsavara

@radical radical added arch-wasm WebAssembly architecture area-System.Net.Http disabled-test The test is disabled in source code against the issue labels Jul 9, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 9, 2022
@ghost
Copy link

ghost commented Jul 9, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The bump to emsdk 3.1.12 - #70693 also switches the windows library tests to run on Chrome, instead of V8. And this causes some more tests to be run.

System.Net.Http.Functional.Tests*EventSource_ExistsWithCorrectId are failing:

public void EventSource_ExistsWithCorrectId()
{
Type esType = typeof(HttpClient).Assembly.GetType("System.Net.NetEventSource", throwOnError: true, ignoreCase: false);
Assert.NotNull(esType);
Assert.Equal("Private.InternalDiagnostics.System.Net.Http", EventSource.GetName(esType));

[FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_DiagnosticsTest_Http2.EventSource_ExistsWithCorrectId
Assert.Equal() Failure
          ↓ (pos 0)
Expected: Private.InternalDiagnostics.System.Net.Ht···
Actual:   NetEventSource
          ↑ (pos 0)
   at System.Net.Http.Functional.Tests.DiagnosticsTest.EventSource_ExistsWithCorrectId()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )

[FAIL] System.Net.Http.Functional.Tests.SyncHttpHandler_DiagnosticsTest.EventSource_ExistsWithCorrectId
Assert.Equal() Failure
          ↓ (pos 0)
Expected: Private.InternalDiagnostics.System.Net.Ht···
Actual:   NetEventSource
          ↑ (pos 0)
   at System.Net.Http.Functional.Tests.DiagnosticsTest.EventSource_ExistsWithCorrectId()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )

[FAIL] System.Net.Http.Functional.Tests.SocketsHttpHandler_DiagnosticsTest_Http11.EventSource_ExistsWithCorrectId
Assert.Equal() Failure
          ↓ (pos 0)
Expected: Private.InternalDiagnostics.System.Net.Ht···
Actual:   NetEventSource
          ↑ (pos 0)
   at System.Net.Http.Functional.Tests.DiagnosticsTest.EventSource_ExistsWithCorrectId()
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )

cc @lambdageek @pavelsavara

Author: radical
Assignees: -
Labels:

arch-wasm, area-System.Net.Http, disabled-test

Milestone: -

@lewing lewing added this to the 8.0.0 milestone Jul 13, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 13, 2022
@lewing
Copy link
Member

lewing commented Jul 25, 2022

cc @lateralusX @lambdageek

radical added a commit to radical/runtime that referenced this issue May 2, 2023
@pavelsavara pavelsavara self-assigned this Jul 12, 2023
@lewing lewing modified the milestones: 8.0.0, 9.0.0 Jul 25, 2023
@ilonatommy ilonatommy changed the title [wasm] System.Net.Http.Functional.Tests*EventSource_ExistsWithCorrectId failing on Windows/Chrome [wasm] System.Net.Http.Functional.Tests*EventSource_ExistsWithCorrectId failing on browser Jun 3, 2024
@ilonatommy
Copy link
Member

Still a problem. This is not only Windows - Chrome, also Linux - chrome/firefox

[FAIL] System.Net.Http.Functional.Tests.TelemetryTest_Http20.EventSource_ExistsWithCorrectId
[FAIL] System.Net.Http.Functional.Tests.TelemetryTest_Http11.EventSource_ExistsWithCorrectId
   Assert.Equal() Failure: Strings differ
                    ↓ (pos 0)
   Expected: "System.Net.Http"
   Actual:   "HttpTelemetry"

@ilonatommy ilonatommy added the os-browser Browser variant of arch-wasm label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-System.Net.Http disabled-test The test is disabled in source code against the issue os-browser Browser variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

5 participants