Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Net.NameResolution.Tests.GetHostAddressesTest_Cancellation.DnsGetHostAddresses_PostCancelledToken_Throws failing in CI #78909

Open
jakobbotsch opened this issue Nov 28, 2022 · 7 comments
Labels
area-System.Net blocking-clean-ci-optional Blocking optional rolling runs disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Milestone

Comments

@jakobbotsch
Copy link
Member

Failure: https://dev.azure.com/dnceng-public/public/_build/results?buildId=94183&view=ms.vss-test-web.build-test-results-tab
Console log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-78879-merge-4f7487e318c446cc92/System.Net.NameResolution.Functional.Tests/3/console.b90e962b.log?helixlogtype=result

This has failed before: #69993. Back then it was disabled in jitstress (in #70089), but note that no stress modes are set in the scenario that failed.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 28, 2022
@ghost
Copy link

ghost commented Nov 28, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Failure: https://dev.azure.com/dnceng-public/public/_build/results?buildId=94183&view=ms.vss-test-web.build-test-results-tab
Console log: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-78879-merge-4f7487e318c446cc92/System.Net.NameResolution.Functional.Tests/3/console.b90e962b.log?helixlogtype=result

This has failed before: #69993. Back then it was disabled in jitstress (in #70089), but note that no stress modes are set in the scenario that failed.

Author: jakobbotsch
Assignees: -
Labels:

area-System.Net

Milestone: -

@jakobbotsch jakobbotsch added the blocking-clean-ci-optional Blocking optional rolling runs label Nov 28, 2022
@jakobbotsch
Copy link
Member Author

@jakobbotsch
Copy link
Member Author

jakobbotsch commented Nov 28, 2022

@rzikm @wfurt @antonfirsov If the flakiness cannot be fixed, can we add some kind of retry mechanism in the test, so that we only fail if e.g. 5/5 tries fail?

@rzikm
Copy link
Member

rzikm commented Nov 28, 2022

There is global retry mechanism for all networking tests, the CI fails the test if it fails 3 times in a row.

@wfurt
Copy link
Member

wfurt commented Nov 28, 2022

We should kick it to outerloop e.g. same as DnsGetHostEntry_PostCancelledToken_Throws.
Curiously the TestSettings.UncachedHost is used in multiple places so it may not work with negative caching.
retries may have similar problem.

@rzikm
Copy link
Member

rzikm commented Dec 5, 2022

Triage: All tests touching external host should be moved to outerloop. We should have a look in 8.0 timeframe

@rzikm rzikm added this to the 8.0.0 milestone Dec 5, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Dec 5, 2022
@karelz karelz added the test-run-core Test failures in .NET Core test runs label Jan 3, 2023
@antonfirsov antonfirsov self-assigned this Jan 17, 2023
@stephentoub stephentoub added the disabled-test The test is disabled in source code against the issue label Jan 19, 2023
@carlossanlop
Copy link
Member

carlossanlop commented Apr 12, 2023

I'm seeing this test fail in 6.0. @antonfirsov can you please disable the test in the servicing branches?

Unfortunately the original issue has very old links which are already gone, so I can't tell for sure if the failure was the same.

The failure I am seeing in 6.0 is weird, because only the build output shows up, but is no test result link being generated.

  Uploading payload for D:\a\_work\1\s\.packages\microsoft.dotnet.helix.sdk\6.0.0-beta.23211.7\tools\azure-pipelines\reporter
  Uploading payload for C:\Users\cloudtest\AppData\Local\Temp\014c4abfe6534f26a0f156d48655d35e
  Created job list at https://helixde107v0xdeko0k025g8.blob.core.windows.net/helix-job-9831ff69-d2cf-4bae-bfb9-946b611bcbbd77c2af293af4a51bf/job-list-c7ea2267-2b1c-4c0b-b4d3-47a0c2ad07ad.json
  Sent Helix Job; see work items at https://helix.dot.net/api/jobs/e1e13316-1c99-4285-8544-eff1b3ee83f0/workitems?api-version=2019-06-17
  Waiting for completion of job e1e13316-1c99-4285-8544-eff1b3ee83f0 on Windows.10.Amd64.Open
  Job e1e13316-1c99-4285-8544-eff1b3ee83f0 on Windows.10.Amd64.Open is completed with 277 finished work items.
  Stopping Azure Pipelines Test Run net6.0-windows-Debug-x64-CoreCLR_checked-Windows.10.Amd64.Open
D:\a\_work\1\s\.packages\microsoft.dotnet.helix.sdk\6.0.0-beta.23211.7\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(43,5): error : Test System.Net.NameResolution.Tests.GetHostAddressesTest_Cancellation.DnsGetHostAddresses_PostCancelledToken_Throws has failed. Check the Test tab for details. [D:\a\_work\1\s\src\libraries\sendtohelixhelp.proj]
##[error].packages\microsoft.dotnet.helix.sdk\6.0.0-beta.23211.7\tools\azure-pipelines\AzurePipelines.MultiQueue.targets(43,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test System.Net.NameResolution.Tests.GetHostAddressesTest_Cancellation.DnsGetHostAddresses_PostCancelledToken_Throws has failed. Check the Test tab for details.

Build FAILED.

@wfurt wfurt modified the milestones: 8.0.0, Future Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net blocking-clean-ci-optional Blocking optional rolling runs disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
None yet
Development

No branches or pull requests

7 participants