Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lsraRegOrder and buildPhysRegRecords to skip non-AVX512 registers if AVX512 not available #81847

Closed
Tracked by #77034
anthonycanino opened this issue Feb 8, 2023 · 6 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture
Milestone

Comments

@anthonycanino
Copy link
Contributor

Per comment #79544 (comment) : we can optimize this section of the code to only use/initialize the AVX512 register records if AVX512 is detected at runtime. See commit 3c7acdb for a rough idea of how to structure these changes.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 8, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Per comment #79544 (comment) : we can optimize this section of the code to only use/initialize the AVX512 register records if AVX512 is detected at runtime. See commit 3c7acdb for a rough idea of how to structure these changes.

Author: anthonycanino
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Feb 8, 2023
@BruceForstall BruceForstall added this to the 8.0.0 milestone Feb 8, 2023
@BruceForstall BruceForstall added the avx512 Related to the AVX-512 architecture label Feb 8, 2023
@anthonycanino
Copy link
Contributor Author

@JulieLeeMSFT please assign me, we are working on this internally.

@tannergooding
Copy link
Member

This was partially covered by #83862

@anthonycanino
Copy link
Contributor Author

anthonycanino commented Apr 6, 2023

@tannergooding when I wrote this issue, this is the optimization I had in mind (#83862), i.e., fix some of the lsraRegOrder pertaining to the extra AVX512 registers.

Did you have something else in mind?

@tannergooding
Copy link
Member

No, I had just interpreted the title as implying something additional. If everything intended to be covered was, then please feel free to close

@BruceForstall
Copy link
Member

This is complete.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture
Projects
None yet
Development

No branches or pull requests

3 participants