Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization on LinearScan::buildPhysRegRecords #83862

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Optimization on LinearScan::buildPhysRegRecords #83862

merged 3 commits into from
Apr 1, 2023

Conversation

Ruihan-Yin
Copy link
Contributor

@Ruihan-Yin Ruihan-Yin commented Mar 23, 2023 •
edited
Loading

introducing separate macro on upper 16 zmm registers and lower 16 zmm registers, skipping upper 16 registers unless on 64-bit system.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 23, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 23, 2023
@ghost
Copy link

ghost commented Mar 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

introducing separate macro on higher 16 zmm registers and lower 16 zmm registers, skipping non-AVX512 register if AVX512 not available.

Author: Ruihan-Yin
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@Ruihan-Yin
Copy link
Contributor Author

@dotnet-policy-service agree company="Intel Corporation"

@build-analysis build-analysis bot mentioned this pull request Mar 24, 2023
Closed
@Ruihan-Yin Ruihan-Yin force-pushed the lsraRegOrder branch 2 times, most recently from 8ff92c7 to f640316 Compare March 27, 2023 17:41
@Ruihan-Yin
Copy link
Contributor Author

some tests failed, but it seems not to be caused by the changes in this PR.

@Ruihan-Yin Ruihan-Yin marked this pull request as ready for review March 27, 2023 23:16
@tannergooding
Copy link
Member

Failure is unrelated and being handled by #84012

@Ruihan-Yin
put the upper register group declaration in global
42ae0c0 
fix the offset value when allocating upper registers, it should
be the length of the lower register group.
@Ruihan-Yin
Copy link
Contributor Author

@tannergooding Hi, is there anything further we need to do? Or this PR is ready to be merged.

kunalspathak
kunalspathak approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It seems the TP regression shows up because helix machines has EVEX encoding and this PR adds the extra check for it? @tannergooding - is that the right conclusion?

image

@kunalspathak kunalspathak merged commit d6455cb into dotnet:main Apr 1, 2023
@Ruihan-Yin
Copy link
Contributor Author

Thanks all!

@tannergooding tannergooding mentioned this pull request Apr 6, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruihan-Yin @tannergooding @kunalspathak