-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Metrics for System.Net.Http #88384
Comments
Tagging subscribers to this area: @dotnet/ncl Issue DetailsOpening a separate issue for the HTTP part of #79371, also including requests from #79459. We should eventually implement the Metrics counterpart of all System.Net.Http EventCounters. The following counters already have their Metrics counterparts specified and tracked by #84978
Event counters not discussed in #84978
Additional requests from #79459, not listed above
Regarding tags, there is a wish in #79459:
|
@davidfowl all connection instruments from #84978 have been added now. I mistakenly though that |
Yes, that's very important to add. One of the most important counters when looking at slowness of requests. |
|
Opening a separate issue for the HTTP part of #79371, also including requests from #79459. We should eventually implement the Metrics counterpart of all System.Net.Http EventCounters.
Implemented as part of #84978
requests-failed
,current-requests
http(11|20|30)-connections-current-total
Note that Metrics variants of
requests-failed
,current-requests
will be semantically different from EventCounters since we need to comply with the OTel specification which wants us to record the counters until "headers receieved" and exclude response buffering in caseHttpCompletionOption.ResponseContentRead
is passed. See the discussion in open-telemetry/opentelemetry-specification#3520.Event counters not discussed in #84978
requests-started
requests-started-rate
requests-failed-rate
http(11|20|30)-requests-queue-duration
Additional requests from #79459; we don't have existing counters for these
Regarding tags, there is a wish in #79459:
The text was updated successfully, but these errors were encountered: