Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiered Jitting: Fix IL to native mapping for ETW #9249

Closed
noahfalk opened this issue Nov 9, 2017 · 1 comment
Closed

Tiered Jitting: Fix IL to native mapping for ETW #9249

noahfalk opened this issue Nov 9, 2017 · 1 comment

Comments

@noahfalk
Copy link
Member

noahfalk commented Nov 9, 2017

ETW emits a Native->IL mapping data for each jitted version and doing code review I can see that it probably isn't emitting the correct mapping.

https://github.com/dotnet/coreclr/blob/master/src/vm/eventtrace.cpp#L6667

The signature of this method uses a MethodDesc and a ReJITID, neither of which is a strong enough identifier to isolate which version of tiered jitting code is being refered to. Without knowing which jitted instance to emit the IL->Native map for and knowing that the maps differ, at least some of the versions must be wrong.

@davmason
Copy link
Member

Fixed with dotnet/coreclr#15038

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants