Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Default interfaces] Support for default interface method devirtualization #9588

Open
MichalStrehovsky opened this issue Jan 23, 2018 · 0 comments
Open

[Default interfaces] Support for default interface method devirtualization #9588

MichalStrehovsky opened this issue Jan 23, 2018 · 0 comments
Labels
area-TypeSystem-coreclr tenet-performance Performance related issue
Milestone
Future

Comments

@MichalStrehovsky
Copy link
Member

Interface methods on generic types require an instantiating stub which the current devirtualization code doesn't provide.

This is just a perf issue, not a correctness issue.
MichalStrehovsky referenced this issue in MichalStrehovsky/coreclr Jan 23, 2018
@MichalStrehovsky
Do not devirtualize shared default interface methods
8f3ebe1 
The result of the devirtualization for a method on a generic type should be an instantiating stub, but this doesn't seem to work right.

Fixing that is a perf issue (that can be triaged/punted - #15977). This commit is a correctness fix to avoid bad codegen for that case.

Resolves #15591.
jkotas referenced this issue in dotnet/coreclr Jan 24, 2018
@MichalStrehovsky @jkotas
Do not devirtualize shared default interface methods (#15979)
3211c25 
The result of the devirtualization for a method on a generic type should be an instantiating stub, but this doesn't seem to work right.

Fixing that is a perf issue (that can be triaged/punted - #15977). This commit is a correctness fix to avoid bad codegen for that case.

Resolves #15591.
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@MichalStrehovsky MichalStrehovsky mentioned this issue Jul 16, 2020
Closed
@mangod9 mangod9 modified the milestones: Future, 6.0.0 Sep 17, 2020
@Rattenkrieg Rattenkrieg mentioned this issue Oct 20, 2020
Closed
@mangod9 mangod9 modified the milestones: 6.0.0, 7.0.0 Jul 9, 2021
@mangod9 mangod9 modified the milestones: 7.0.0, Future Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-TypeSystem-coreclr tenet-performance Performance related issue
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Instantiating stub for devirtualized default interface method on a generic type Rattenkrieg/runtime
3 participants
@msftgits @MichalStrehovsky @mangod9