Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HalfNumberBufferLength #100187

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix HalfNumberBufferLength #100187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4da16c9
Fix HalfNumberBufferLength
huoyaoyuan Mar 23, 2024
4d3d4b1
Add regression test
huoyaoyuan Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/src/System/Number.NumberBuffer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ internal static partial class Number
internal const int Int64NumberBufferLength = 19 + 1; // 19 for the longest input: 9,223,372,036,854,775,807
internal const int Int128NumberBufferLength = 39 + 1; // 39 for the longest input: 170,141,183,460,469,231,731,687,303,715,884,105,727
internal const int SingleNumberBufferLength = 112 + 1 + 1; // 112 for the longest input + 1 for rounding: 1.40129846E-45
internal const int HalfNumberBufferLength = 21; // 19 for the longest input + 1 for rounding (+1 for the null terminator)
internal const int HalfNumberBufferLength = 21 + 1 + 1; // 21 for the longest input + 1 for rounding: 0.000122010707855224609375
internal const int UInt32NumberBufferLength = 10 + 1; // 10 for the longest input: 4,294,967,295
internal const int UInt64NumberBufferLength = 20 + 1; // 20 for the longest input: 18,446,744,073,709,551,615
internal const int UInt128NumberBufferLength = 39 + 1; // 39 for the longest input: 340,282,366,920,938,463,463,374,607,431,768,211,455
Expand Down
8 changes: 8 additions & 0 deletions src/libraries/System.Runtime/tests/System.Runtime.Tests/System/HalfTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,6 +1125,14 @@ public static void ToStringRoundtrip_R(object o_value)
AssertExtensions.Equal((Half)value, result);
}

[Fact] // https://github.com/dotnet/runtime/issues/98841
public static void ToString_MaxPrecision()
{
Half value = BitConverter.Int16BitsToHalf(0x07FF);
string str = value.ToString("F24");
Assert.Equal("0.000122010707855224609375", str);
}

public static IEnumerable<object[]> RoundTripFloat_CornerCases()
{
// Magnitude smaller than 2^-24 maps to 0
Expand Down