[wasm] Change export name mangling to match expectations #100652

lewing · 2024-04-04T19:10:02Z

maraf

Is it based on some general convention? Could we add link in the comment?
If it's not a convention, should it be configurable?

Change change export name mangling to match expectations

4a222f0

lewing requested review from maraf and akoeplinger as code owners April 4, 2024 19:10

dotnet-issue-labeler bot added the area-Build-mono label Apr 4, 2024

dotnet-policy-service bot assigned lewing Apr 4, 2024

lewing requested a review from mkhamoyan April 4, 2024 19:22

maraf approved these changes Apr 5, 2024

View reviewed changes

lewing merged commit 55535ed into dotnet:main Apr 5, 2024
31 of 33 checks passed

lewing deleted the wasi-mangling branch April 5, 2024 19:04

lewing mentioned this pull request Apr 11, 2024

[wasm] UnmanagedCallersOnly generates incorrect wasm export types #96853

Closed

matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024

Change change export name mangling to match expectations (dotnet#100652)

ea05022

github-actions bot locked and limited conversation to collaborators May 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] Change export name mangling to match expectations #100652

[wasm] Change export name mangling to match expectations #100652

lewing commented Apr 4, 2024 •

edited

maraf left a comment

[wasm] Change export name mangling to match expectations #100652

[wasm] Change export name mangling to match expectations #100652

Conversation

lewing commented Apr 4, 2024 • edited

maraf left a comment

Choose a reason for hiding this comment

lewing commented Apr 4, 2024 •

edited