[PERF] Move performance testing logic into python scripts #101143
+162
−1,336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that the draft PR got automatically assigned some reviewers, I'll reping the reviewers once I move this out of draft as it's not ready for review just yet outside of my team. |
This was referenced Apr 17, 2024
Open
LoopedBard3
reviewed
Apr 18, 2024
| @@ -66,6 +65,7 @@ jobs: | |||
| iosStripSymbols: ${{ parameters.iosStripSymbols }} | |||
| hybridGlobalization: ${{ parameters.hybridGlobalization }} | |||
| timeoutInMinutes: ${{ parameters.timeoutInMinutes }} | |||
| extraSetupParameters: $(extraSetupParameters) | |||
There was a problem hiding this comment.
Where is the extraSetupParameters coming from? Does the initialization below get replaced above/here.
LoopedBard3
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Is this added folder(?) added on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is being made so that as much of the performance testing logic is runnable and testable locally as possible, and centralised inside the performance repository rather than the runtime repository. Right now, a lot of the logic sits inside Azure Pipelines yaml files that are difficult to debug and can't be run locally. With this, it will be possible to build on top of it support to schedule performance tests to be sent to Helix from a local machine using local code.
In addition, this change also moves the logic that checks out the performance repository from a script into an Azure Pipelines
checkoutstep using Azure Pipeline's multi-repo checkout functionality. With this, you can now easily see the version of the runtime and performance repository being used for a performance test run. I have also added a "branch" parameter to the runtime performance test pipelines which will let you specify a custom branch off the performance repository to be used in case you have a change that needs to be coordinated against both repositories at the same time.This change is dependent on dotnet/performance#4156 and must be merged after the change to the performance repository is merged in. Both PRs should be reviewed as one piece however as they are both built for the same feature.