Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in a half numbers #101182

Closed
wants to merge 1 commit into from
Closed

Conversation

kant2002
Copy link
Contributor

No description provided.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 17, 2024
@danmoseley
Copy link
Member

Does this need a matching test or test change?

@kant2002
Copy link
Contributor Author

I don't see any tests infrastructure for these formatting. it fails in rare case

short yyy = 2047;
var h = *((Half*)(short*)&yyy);  // this is only to simulate specific number.
var s = (h).ToString("F24");
Console.WriteLine("{0}", s); 

actual number is in the comment.

@kant2002
Copy link
Contributor Author

Seems to be this is fixed #100187 ?

@tannergooding
Copy link
Member

Yes, this should already be resolved with #100187 and there should be no remaining failure cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants