-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse more templates in our build #101197
Conversation
…jobs as strongly-typed template parameters don't allow unknown parameters and I don't want to declare a ton of optional ones we aren't going to ever use.
… (to get it in the right place in the pipeline)
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Seems like all failures are unrelated. Would we benefit from also running the outerloop pipeline? |
This change only affects the runtime and runtime-official pipelines, so there's no need to run any outerloop pipelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment/change, LGTM otherwise
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Make the generate-offsets and workloads jobs based on the global-build-job template.
Make the publish-signed-artifacts job based on the Arcade template and use more 1ES pipeline features (as it's internal only and doesn't need to run in a non-1ES context).