Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse more templates in our build #101197

Merged
merged 15 commits into from
Apr 19, 2024

Conversation

jkoritzinsky
Copy link
Member

Make the generate-offsets and workloads jobs based on the global-build-job template.

Make the publish-signed-artifacts job based on the Arcade template and use more 1ES pipeline features (as it's internal only and doesn't need to run in a non-1ES context).

@jkoritzinsky
Copy link
Member Author

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@ivdiazsa
Copy link
Member

Seems like all failures are unrelated. Would we benefit from also running the outerloop pipeline?

@jkoritzinsky
Copy link
Member Author

This change only affects the runtime and runtime-official pipelines, so there's no need to run any outerloop pipelines.

@jkoritzinsky jkoritzinsky requested a review from a team April 18, 2024 01:01
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment/change, LGTM otherwise

eng/pipelines/runtime-official.yml Outdated Show resolved Hide resolved
eng/pipelines/runtime-official.yml Outdated Show resolved Hide resolved
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants