[wasm] Optimize out references to a bunch of BCL methods during JS interop startup #101217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
|
Is there a reason not to do the parsing in js or unmanaged? |
|
We could move it all there, yeah. It's just more invasive. Happy to do it. |
This was referenced Apr 18, 2024
|
Took some measurements, and this reduces the % of total startup JS samples underneath |
pavelsavara
reviewed
Apr 18, 2024
I think it's next logical step 🤣 See c34474e
now seriously, i'm OK with moving it back, it seems we only needed to parse it on C# side in order to format that |
Remove interpolated string from jsinterop startup
kg
force-pushed
the
bind-assembly-exports-1
branch
from
6b97da5
to
1ae3734
Compare
This was referenced Apr 19, 2024
3 tasks
pavelsavara
approved these changes
Apr 19, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…terop startup (dotnet#101217) During startup for a simple wasm browser app, by my testing the interpreter has to generate code for ~870 methods. This PR reduces it to ~750. Most of the methods removed are SIMD-related, i.e. vector infrastructure or vectorized string algorithms. The interpolated string also pulls in a ton of threading and synchronization stuff due to renting from a pool. In the future we could move all of this string logic into C or JS to avoid involving managed code at all, since the resulting string is not used by C#.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During startup for a simple wasm browser app, by my testing the interpreter has to generate code for ~870 methods. This PR reduces it to ~750.
Most of the methods removed are SIMD-related, i.e. vector infrastructure or vectorized string algorithms. The interpolated string also pulls in a ton of threading and synchronization stuff due to renting from a pool.