Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the copy propagation type check to local field cases #101256

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Extend the copy propagation type check to local field cases #101256

merged 2 commits into from
Apr 19, 2024

Conversation

SingleAccretion
Copy link
Contributor

NOL locals are not modeled faithfully by VN, which makes this type check universally necessary.

No significant diffs expected.

Fixes #101034.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 18, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@SingleAccretion SingleAccretion changed the title Extend the copy propagation type check to local fields Extend the copy propagation type check to local field cases Apr 18, 2024
@SingleAccretion SingleAccretion marked this pull request as ready for review April 19, 2024 10:41
@SingleAccretion
Copy link
Contributor Author

Replay failure looks like #101070.

Diffs: one diff in the affected test method.

Some TP diffs that look like native compiler noise: unfortunately, optCopyProp is a very hot function.

@SingleAccretion SingleAccretion requested a review from a team April 19, 2024 10:44
jakobbotsch
jakobbotsch approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this.

@jakobbotsch jakobbotsch merged commit 6e05198 into dotnet:main Apr 19, 2024
114 of 116 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@SingleAccretion @matouskozak
Extend the copy propagation type check to local field cases (dotnet#1…
c955cc3 
…01256)

NOL locals are not modeled faithfully by VN, which makes this type check universally necessary.
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure: System.Runtime.CompilerServices.UnsafeTests.BitCast
2 participants
@SingleAccretion @jakobbotsch