Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Remove Compiler::fgCanonicalizedFirstBB #101358

Merged
merged 1 commit into from
Apr 22, 2024
Merged

JIT: Remove Compiler::fgCanonicalizedFirstBB #101358

merged 1 commit into from
Apr 22, 2024

Conversation

amanasifkhalid
Copy link
Member

We never read Compiler::fgCanonicalizedFirstBB -- I'm guessing this was introduced as a quirk during the loop representation refactor, and the behavior dependent on it was eventually phased out.

cc @dotnet/jit-contrib, @jakobbotsch PTAL; this should be a no-diff change.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 21, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jakobbotsch
jakobbotsch approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm guessing this was introduced as a quirk during the loop representation refactor, and the behavior dependent on it was eventually phased out.

Yep, it was added in #95809 and I forgot to remove it in #97232 when I deleted old loop finding.

@amanasifkhalid
Copy link
Member Author

No diffs. SPMI failures look like #101070.

@amanasifkhalid amanasifkhalid merged commit 7a5542d into dotnet:main Apr 22, 2024
108 of 110 checks passed
@amanasifkhalid amanasifkhalid deleted the fgFirstBB-quirk branch April 22, 2024 15:26
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@amanasifkhalid @matouskozak
JIT: Remove fgCanonicalizedFirstBB (dotnet#101358)
3ee2e8a
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amanasifkhalid @jakobbotsch