Use bison for ilasm parser generator #101415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
hez2010
commented
Apr 23, 2024
| @@ -42,13 +42,13 @@ | |||
| }; | |||
|
|
|||
| /* These are returned by the LEXER and have values */ | |||
| %token ERROR_ BAD_COMMENT_ BAD_LITERAL_ /* bad strings, */ | |||
There was a problem hiding this comment.
ERROR_ has been defined multiple times, so remove it here.
hez2010
commented
Apr 23, 2024
| @@ -96,7 +96,7 @@ | |||
| %token _CLASS _NAMESPACE _METHOD _FIELD _DATA _THIS _BASE _NESTER | |||
| %token _EMITBYTE _TRY _MAXSTACK _LOCALS _ENTRYPOINT _ZEROINIT | |||
| %token _EVENT _ADDON _REMOVEON _FIRE _OTHER | |||
| %token _PROPERTY _SET _GET DEFAULT_ | |||
There was a problem hiding this comment.
DEFAULT_ has been defined multiple times, so remove it here.
hez2010
commented
Apr 23, 2024
Comment on lines
+50
to
+51
| %token <int32> INT32_V /* 3425 0x34FA 0352 */ | ||
| %token <int64> INT64_V /* 342534523534534 0x34FA434644554 */ |
There was a problem hiding this comment.
They are conflicting with INT32 and INT64 typedef, so rename them.
|
Thank you @hez2010 ! Will review this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #89704. Fixes #4776.
Bison for Windows: https://github.com/lexxmark/winflexbison
For other platforms: https://www.gnu.org/software/bison
To generate the
asmparse.cpp:yacc asmparse.y -o asmparse.cpp(orwin_bison asmparse.y -o asmparse.cpp)I have deleted the
asmparse.grammarfile as it's no longer being maintained since 2021./cc: @TIHan @JulieLeeMSFT