Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TensorPrimitives.Max/MinNumber #101435

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Add TensorPrimitives.Max/MinNumber #101435

merged 2 commits into from
Apr 25, 2024

Conversation

stephentoub
Copy link
Member

Contributes to #98862

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 23, 2024
Closed
Open
Open
Closed
Closed
Open
This was referenced Apr 25, 2024
Closed
Open
Closed
Open
@build-analysis build-analysis bot mentioned this pull request Apr 25, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Apr 25, 2024
Closed
@stephentoub stephentoub merged commit 90c81b2 into dotnet:main Apr 25, 2024
79 of 84 checks passed
@stephentoub stephentoub deleted the tpmaxminnumber branch April 25, 2024 20:41
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@stephentoub @matouskozak
Add TensorPrimitives.Max/MinNumber (dotnet#101435)
c6cb51f 
* Add TensorPrimitives.Max/MinNumber

* Address PR feedback plus some cleanup
@build-analysis build-analysis bot mentioned this pull request May 2, 2024
Open
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@stephentoub @michaelgsharp
Add TensorPrimitives.Max/MinNumber (dotnet#101435)
6182aa4 
* Add TensorPrimitives.Max/MinNumber

* Address PR feedback plus some cleanup
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Numerics new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephentoub @eiriktsarpalis @tannergooding