Add hostfxr_resolve_frameworks_for_runtime_config for resolving runtime frameworks
#101451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
elinor-fung
force-pushed
the
resolveFrameworks-api
branch
from
d43b845
to
a0839bf
Compare
This was referenced Apr 24, 2024
Closed
elinor-fung
force-pushed
the
resolveFrameworks-api
branch
from
a0839bf
to
bfc60ed
Compare
This was referenced Apr 24, 2024
Closed
Closed
elinor-fung
force-pushed
the
resolveFrameworks-api
branch
from
738398e
to
c0c56c4
Compare
This was referenced Apr 25, 2024
elinor-fung
force-pushed
the
resolveFrameworks-api
branch
from
c0c56c4
to
bc0c10c
Compare
src/installer/tests/Assets/Projects/HostApiInvokerApp/Program.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
May 7, 2024
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…time frameworks (dotnet#101451) - `hostfxr_resolve_frameworks_for_runtime_config` provides a way to run the host's runtime framework resolution in an isolated manner - Return code indicates basic success/failure and the optional callback can be used for additional information about what was or was not resolved - For framework-dependent, runs through framework resolution and propagates the result - Currently `unresolved_count` will always either be 0 or 1 - the host stops at the first failed resolution - For self-contained, any `includedFrameworks` per the runtime config are treated as resolved to the app's directory - Add tests to `NativeHostApis` tests and update `HostApiInvokerApp` test asset to exercise new API - Update tests to stop copying hostfxr next to the app - pass in the paths via runtime config and make the test app resolve the load via DllImportResolver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new
hostfxrAPI per #99027hostfxr_resolve_frameworks_for_runtime_configprovides a way to run the host's runtime framework resolution in an isolated mannerunresolved_countwill always either be 0 or 1 - the host stops at the first failed resolutionincludedFrameworksper the runtime config are treated as resolved to the app's directoryNativeHostApistests and updateHostApiInvokerApptest asset to exercise new APIResolves #99027
cc @dotnet/appmodel @vitek-karas