Change S.R.M.TypeName to be consumed from System.Reflection.Metadata package #101666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-Tools-ILVerification
jkotas
added
area-System.Reflection.Metadata
and removed
area-Tools-ILVerification
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata |
jkotas
changed the title
|
This should be enough to fix the build breaks in outer loop and source build. Further cleanup is tracked by #101541. |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
changed the title
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…package Contributes to dotnet#101541 Fixes dotnet#101628 Better unreachable code elimination in CoreLib
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeffhandley
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thank you, @jkotas. I appreciate you digging into this before I was able to get to it and before code flow was adversely disrupted.
This was referenced Apr 29, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…package (dotnet#101666) Contributes to dotnet#101541 Fixes dotnet#101628
|
@jkotas @jeffhandley big thanks on fixing the issue when I was offline! |
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…package (dotnet#101666) Contributes to dotnet#101541 Fixes dotnet#101628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #101541
Fixes #101628