Arm64/Sve: Add SignExtend* and ZeroExtend* math APIs #101702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
|
@dotnet/arm64-contrib |
This was referenced Apr 30, 2024
| @@ -448,14 +448,13 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node) | |||
| if (intrin.op3->isContained()) | |||
| { | |||
| assert(intrin.op3->IsVectorZero()); | |||
| if (intrin.op1->isContained()) | |||
| if (intrin.op1->isContained() || intrin.op1->IsMaskAllBitsSet()) | |||
There was a problem hiding this comment.
The intrin.op1->isContained() seems pointless here, no?
We just need to know its not contained for an instruction that actually requires its use (like abs)
There was a problem hiding this comment.
i will have to double check on this one. There was lot of back and forth on this for certain scenarios. I will verify it on next round.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Add [Sign|Zero]Extend[8|16|32] APIs: * Add API to instruction mapping * eliminate extra movprfx for AllBitsSetMask * Add test cases
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
* Add [Sign|Zero]Extend[8|16|32] APIs: * Add API to instruction mapping * eliminate extra movprfx for AllBitsSetMask * Add test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passing: https://gist.github.com/kunalspathak/d8c244f02f51e1a9e247f97f9d23b9e3
Contributes to #99957