Provide MSBuild properties to use the new libc++ configuration we plan on using in our builds #101773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n on using in our builds.
…ers that we've migrated to azurelinux-3.0-based containers.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
sbomer
reviewed
May 1, 2024
Co-authored-by: Sven Boemer <sbomer@gmail.com>
This was referenced May 2, 2024
…ge the entry-point ones to be different so MSBuild global property behavior doesn't break things).
Co-authored-by: Sven Boemer <sbomer@gmail.com>
|
Now that the images have been published, let's try to use the new features. |
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-sanitized |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like there's some failures due to some of the later changes I made in the images that I didn't go back and re-validate. I'll only opt-in to the new images for the sanitizer build (which is failing for other reasons) but I'll keep the infra around for when I fix the problem. |
sbomer
approved these changes
May 14, 2024
|
Blocked on dotnet/dotnet-buildtools-prereqs-docker#1055 |
|
/ba-g Timeouts unrelated |
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…n on using in our builds (dotnet#101773) Co-authored-by: Sven Boemer <sbomer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to switch our Microsoft shipping builds to statically link to a live-built libc++ with a dynamically-linked libstdc++ as the C++ ABI. We're doing this change to address the concerns in #101088 (comment). This change will allow us to use servicable/supported C++ headers in our product with the smallest possible size increase (+~53kB size on disk for libcoreclr.so on our linux-x64 images).
For our AddressSanitizer test legs, we're introducing a new image that instruments libc++ and uses (and instruments) libc++abi for the ABI layer (all statically linked).
Depends on dotnet/dotnet-buildtools-prereqs-docker#1025, but I want to get this UX approved before I merge that PR.
No changes were made in the libraries build as that build is all in C as far as I know.