Don't enable use-after-return checking on Apple's Clang #101781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
1 similar comment
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
danmoseley
reviewed
May 2, 2024
|
/ba-g failures are all Helix infra failures and a helix timeout that's not easy to make a Known Issue for. |
am11
reviewed
May 2, 2024
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
This was referenced May 2, 2024
akoeplinger
approved these changes
May 3, 2024
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
May 4, 2024
While looking at dotnet#101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
May 4, 2024
While looking at dotnet#101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
May 4, 2024
While looking at dotnet#101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
May 4, 2024
While looking at dotnet#101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
May 4, 2024
While looking at dotnet#101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
May 4, 2024
While looking at dotnet#101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
akoeplinger
added a commit
that referenced
this pull request
May 5, 2024
While looking at #101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…101875) While looking at dotnet#101781 I noticed that we weren't catching AppleClang in the CMAKE_C_COMPILER_ID in src/native/libs/CMakeLists.txt because we used STREQUAL instead of MATCHES like we do everywhere else. The result was that we didn't enable `-Weverything` on Apple platforms for the libs.native subset and a bunch of warnings didn't get enabled, this PR fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not compatible with this validation yet and it looks like Apple's Clang is now defaulting to it being enabled now.