Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual] Merge release/8.0-staging into release/8.0 #101832

Merged
merged 33 commits into from
May 3, 2024

Conversation

carlossanlop
Copy link
Member

Merge commit.

dotnet-maestro bot and others added 30 commits April 16, 2024 10:21
…15.1 (dotnet#101047)

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.5-servicing.24211.3 -> To Version 8.0.5-servicing.24215.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update MicrosoftBuildVersion to latest to fix System.Security.Cryptography.XML component governance alert.

* Add info to VersionDetails to allow sourcebuild to update the MSBuild dependency

* Update SourceBuildPrebuiltBaseline.xml

---------

Co-authored-by: Parker Bibus <parkerbibus@microsoft.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Michael Simons <msimons@microsoft.com>
…indows/Linux (dotnet#101109)

* Fix

* Fix template wbt

* Fix config wbt.

* Should fix native wbt but does not.

* Missing change.

* Update src/tasks/AotCompilerTask/MonoAOTCompiler.cs

Co-authored-by: Ankit Jain <radical@gmail.com>

* Double quotes needed, not single.

* Space on Linux should work.

* Backport dotnet#94306

---------

Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com>
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
…nals build 20240416.1 (dotnet#101181)

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.24175.3 -> To Version 8.0.0-alpha.1.24216.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
)

* fix SendTo with SocketAsyncEventArgs

* feedback

---------

Co-authored-by: wfurt <tweinfurt@yahoo.com>
…rmat to be "yyyy" (dotnet#100810)

* fix short date year format on apple hybrid glob.
* add test for ShortDatePattern for iOS hybrid globalization
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
…et#101144)

* Avoid rooting X509Certificate2 in SslSessionCache

* Update src/libraries/System.Net.Security/src/System/Net/Security/SslStreamPal.Windows.cs

Co-authored-by: campersau <buchholz.bastian@googlemail.com>

---------

Co-authored-by: Radek Zikmund <r.zikmund.rz@gmail.com>
Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
* Update EOL OS versions

* Revert missing images

* Revert missing images
…101313)

* Move CoreCLR community platforms to build with the global build template (dotnet#91646)

* Try to disable VSIX update service and collect VS update logs (dotnet#91708)

* Tweak invocations, disable service updates, detect vswhere missing
* Try disabling update early in build
* Only collect logs on official build on exit

---------

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
…taging (dotnet#101579)

* Stop skipping tests in installer pipeline on linux_x64 (dotnet#89953)

- Run tests in in installer pipeline on Linux_x64 even though it is cross-build. 
- Fix uploading of binaries/symbols on failure

* Append job attempt number to log artifact names (dotnet#91658)

Avoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.

* Separate running PAL tests out to their own jobs/steps. (dotnet#91643)

* Separate running PAL tests out to their own jobs/steps.

* Remove PAL tests running infra from the CoreCLR build job and the runtime tests templates.

* !drop Strip out all jobs from runtime.yml and replace with the new PAL tests job to make it easier to test

* Remove dependency on EvaluatePaths

* Reparent job parameters correctly.

* Add back EvaluatePaths step for simplicity

* Set missing properties

* Capitalize build config

* Make a tarball to preserve permission bits.

* Make the output path directory before trying to use it

* Double timeout

* Double timeout again. Looks like Mac needs it.

* Fix metadata name and put back to 10 minutes.

* Move changes to the correct pipeline and revert changes to runtime.yml

* Remove reference to deleted target

---------

Co-authored-by: Elinor Fung <elfung@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
…ild 20240429.2 (dotnet#101688)

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.24210.1 -> To Version 8.0.0-alpha.0.24229.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…e/8.0-to-release/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
…llable value types (dotnet#101491)

This PR extends mono_gsharedvt_constrained_call to handle static MONO_GSHAREDVT_CONSTRAINT_CALL_TYPE_REF calls. If the cmethod is a static method, this_arg should be NULL. Also, it skips dereferencing sharedvt ref arguments if they are nullable value types.
…d dispose FileProvider when it owns it" (dotnet#101610)

* Revert "FileConfigurationProvider.Dispose should dispose FileProvider when it…"

This reverts commit 63fad3c.

* Add test to ensure the bug does not come back

* Enable servicing Microsoft.Extensions.Configuration.FileExtensions

* Update Microsoft.Extensions.Configuration.FileExtensions.csproj

---------

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
* Initial changes

* Enable building in 8.0.6 release
…t#92296) (dotnet#101627)

* Build the PGO build legs through the global build job template.

* Remove pgoType parameters and plumbing from all jobs and use the -pgoinstrument flag instead of setting the property manually.

* Limit subsets to build to limit packages and don't build crossgen2 sfxproj for internal optimization pipelines (we don't use it).

* Fix job dependencies now that the non-global jobs don't have PGO type in the name

* Change back to the triple-underscore name

* Fix Mono artifacts to not have an extra underscore for PGO scenarios.

* There's an extra underscore for the CoreCLR artifacts because there's no runtime variant.

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
…ermine process time coefficient on macOS (dotnet#100122)

* Fix dotnet#91958: use mach_timebase_info to determine process time coefficient on macOS

* (dotnet#91958) Process.OSX: fallback for non-zero exit code from mach_timebase_info

* (dotnet#91958) Process: move OSX-specific tests to a separate file

* (dotnet#91958) Process.OSX: calculate times lazily

* (dotnet#91958) Process: include string resources properly in tests

* (dotnet#91958) Process: more overflow-safe logic

* (dotnet#91958) Minimize diff

* Process.OSX: fix thread safety (dotnet#100260)

Without this fix, it was possible for another thread to see an incorrect
(zero) value of s_timeBase_numer because of a race condition.

---------

Co-authored-by: Friedrich von Never <friedrich@fornever.me>
…der source generator (dotnet#101686)

* Prefer most derived member in Configuration Binder source generator

* Skip overridden properties in config source generator - include only definitions

* Enable shipping Microsoft.Extensions.Configuration.Binder

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
…e/8.0-to-release/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
…d code (dotnet#101290)

Creating a delegate would normally end up calling into the runtime via ves_icall_mono_delegate_ctor. However, jit/aot backand have a fastpath where the delegate is not fully initialized (relying on the delegate trampoline to resolve the actual method to be called when the delegate is first called). Interp delegate initialization therefore doesn't take place. If this is the case and the delegate method is virtual, we would need to resolve it based on the target object.

Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
…#101744)

* Allow multiple post-build steps and allow templated pre and post-build steps (dotnet#92375)

* Convert AllConfigurations and NETFX jobs to use the global build templates (dotnet#93082)

---------

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
…1245)

This reverts commit aee4957.

Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
MichaelSimons and others added 3 commits May 2, 2024 14:16
…02.3 (dotnet#101817)

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.5-servicing.24215.1 -> To Version 8.0.6-servicing.24252.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-codeflow for labeling automated codeflow labels May 3, 2024
@carlossanlop carlossanlop added this to the 8.0.6 milestone May 3, 2024
@carlossanlop carlossanlop self-assigned this May 3, 2024
@carlossanlop
Copy link
Member Author

There's an ILLink.Tasks test failure:

�[m�[31;1m    ILLink.Tasks.Tests.TaskArgumentTests.TestRootDescriptorFiles(rootDescriptorFiles: ["combined_output.xml"]) [FAIL]
�[m�[37m      Assert.Equal() Failure
�[m�[37m                 ↓ (pos 0)
�[m�[37m      Expected: ["combined_output.xml"]
�[m�[37m      Actual:   []
�[m�[37m                 ↑ (pos 0)
�[m�[30;1m      Stack Trace:
�[m�[37m        /_/src/tools/illink/test/ILLink.Tasks.Tests/ILLink.Tasks.Tests.cs(202,0): at ILLink.Tasks.Tests.TaskArgumentTests.TestRootDescriptorFiles(String[] rootDescriptorFiles)

@dotnet/illink-contrib do you see this a a blocker for the release?
I'll open a KnownBuildError issue to track this, regardless.

@carlossanlop carlossanlop merged commit 9b088ab into dotnet:release/8.0 May 3, 2024
351 of 371 checks passed
@carlossanlop carlossanlop deleted the release/8.0-staging branch May 3, 2024 07:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet