JIT: profile checking through inlining

[AndyAyersMS]

Advance profile consistency check through inlining. Turns out there are five reasons why inlining may make profile data inconstent. Account for these and add metrics.

Also add separate metrics for consistency before and after inlining, since pre-inline phases are run on inlinees and so don't give us good insight into overall consistency rates. And add some metrics for inlining itself.

Contributes to #93020.

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[AndyAyersMS]

@amanasifkhalid PTAL
cc @dotnet/jit-contrib

Some stats from ASP.NET (only for methods that have inlines). Roughly 80% consistent going in to inlining, 60% consistent coming out.

Count of Method full name	51654
Sum of ProfileConsistentBeforeInline	41952
Sum of ProfileConsistentAfterInline	33414
Sum of ProfileInconsistentInlinerBranchFold	859
Sum of ProfileInconsistentInlineeScale	0
Sum of ProfileInconsistentInlinee	6158
Sum of ProfileInconsistentNoReturnInlinee	23
Sum of ProfileInconsistentMayThrowInlinee	1498
Sum of InlineAttempt	779761
Sum of InlineCount	775969

Fair number of diffs in some collections. There are two spots where we alter profiles from base that are the likely causes -- I will spot check to make sure nothing else is going on.

1. when the inlinee entry is a loop head, we were under-scaling the inlinee
2. we now make profile adjustments when inliner folds a branch

[AndyAyersMS]

osx-arm64 build issue is a crash in clang:

  clang: error: unable to execute command: Abort trap: 6
  clang: error: clang frontend command failed due to signal (use -v to see invocation)
  Apple clang version 14.0.0 (clang-1400.0.29.202)
  Target: arm64-apple-darwin21.6.0
  Thread model: posix
  InstalledDir: /Applications/Xcode_14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
  [ 76%] Building CXX object vm/wks/CMakeFiles/cee_wks_core.dir/__/stackingallocator.cpp.o
  [ 76%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/jithashtable.cpp.o
  [ 76%] Building CXX object jit/CMakeFiles/clrjit.dir/emitarm64.cpp.o
  [ 76%] Building CXX object jit/CMakeFiles/clrjit_unix_x64_arm64.dir/jitmetadata.cpp.o
  clang: note: diagnostic msg: 
  ********************
  
  PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
  Preprocessed source(s) and associated run script(s) are located at:
  clang: note: diagnostic msg: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/codegenarmarch-0adb77.cpp
  clang: note: diagnostic msg: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/codegenarmarch-0adb77.sh
  clang: note: diagnostic msg: Crash backtrace is located in
  clang: note: diagnostic msg: /Users/runner/Library/Logs/DiagnosticReports/clang_<YYYY-MM-DD-HHMMSS>_<hostname>.crash
  clang: note: diagnostic msg: (choose the .crash file that corresponds to your crash)
  clang: note: diagnostic msg: 
  
  ********************
  make[2]: *** [jit/CMakeFiles/clrjit_universal_arm64_arm64.dir/codegenarmarch.cpp.o] Error 254
  make[1]: *** [jit/CMakeFiles/clrjit_universal_arm64_arm64.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs...

Am going to rerun and hope this is a very intermittent failure, otherwise will try and repro this locally and file a bug.

[AndyAyersMS]

Fyi @EgorBo per above we bail out of inlining late less than 1% of the time

[amanasifkhalid]

LGTM, assuming CI looks good (hopefully that clang failure doesn't become a blocker). Thanks!

[AndyAyersMS]

SPMI failures are lagging collections after a GUID update. Am going to ignore.