WIP: Allow supplying a Regex object to a RegularExpressionAttribute #101972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel-dataannotations |
|
@dotnet-policy-service agree |
mrudat
force-pushed
the
use-regex-with-regular-expression-attribute
branch
from
24e927e
to
862094a
Compare
mrudat
commented
May 7, 2024
| { | ||
| Regex = regex; | ||
| Pattern = regex.ToString(); | ||
| MatchTimeoutInMilliseconds = 2000; |
There was a problem hiding this comment.
TODO: Somehow forward MatchTimeoutInMilliseconds to the Regex object; there's a TimeSpan field for the timeout, but no setter.
|
Thank you for your interest of contribution. Adding new API like methods require going through API review process. Typically pull requests shouldn't be opened before the API is approved. I'm going to close this PR because it won't work at all. You can't really use the attribute constructor with attribute syntax. |
This was referenced May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101965
TODO: