[release/8.0-staging] [WinHttpHandler] Move _cachedSendPinnedBuffer ownership to WinHttpRequestState
#102083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Approved over email. All test failures are unrelated. |
antonfirsov
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #101725 to release/8.0-staging
/cc @antonfirsov
Customer Impact
An internal customer reported a crash (Access Violation). According to our code analysis the crash is caused by a race between
WinHttpRequestStream.WriteAsyncandWinHttpRequestStream.Dispose, where Dispose might unpin the send buffer prematurely. The PR removes the race condition from which we expect that the AV will go away.Regression
Not a regression
Testing
Unfortunately, we were not able to reproduce the issue locally, and the customer wasn't able to do validation for us.
We validated the presence of the fix in the resulting package with a disassembler.
Risk
Low. The change is an adaptation of the logic implemented in PR dotnet/corefx#6500 for .NET Core 1.0 (sending buffer side).