Fix build break in outer loop runtime tests #102115
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -507,6 +507,46 @@ regMaskTP LinearScan::getConstrainedRegMask(RefPosition* refPosition, | |||
| return newMask; | |||
| } | |||
|
|
|||
| //------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
This is fixing build break in Linux debug builds (looks like a bug in the C++ compiler/linker to me):
| @@ -279,10 +279,10 @@ public TestResolver(Dictionary<string, string> simpleNameToPathMap) | |||
| _simpleNameToPathMap = simpleNameToPathMap; | |||
| } | |||
|
|
|||
| PEReader IResolver.ResolveAssembly(AssemblyName assemblyName) | |||
| PEReader IResolver.ResolveAssembly(AssemblyNameInfo assemblyName) | |||
There was a problem hiding this comment.
This is fixing build break in ILVerify tests: https://dnceng-public.visualstudio.com/public/_build/results?buildId=672464&view=logs&j=3725811e-4a8b-5f6a-b03b-a353ee894148&t=d59fccfb-2b13-5841-75bf-bfec705ee16a
There was a problem hiding this comment.
Wondering why this was not caught in CI ran during PR. Is the difference just Debug vs. Release?
fail: /__w/1/s/build.sh -ci -arch arm64 -os linux -cross -s clr -c Debug
pass: /__w/1/s/build.sh -ci -arch arm64 -os linux -cross -s clr+libs+host+packs -rc Release -c Release -lc Release
There was a problem hiding this comment.
Right, the default CI mix builds checked and release coreclr builds only. 99.9+% of debug build breaks are caught by checked builds. It is only outliers like this one (that looks like a C++ compiler bug to me) that can sneak through.
jkotas
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
No description provided.