JIT: Unify GT_JMP handling in the backends
#102117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the handling of `GT_JMP` into a single unified implementation that utilizes the new ABI representation.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced May 12, 2024
|
cc @dotnet/jit-contrib PTAL @kunalspathak Some minor diffs where the new logic allows using some wider reads from the stack for struct locals. This should be fine. |
| { | ||
| JITDUMP("\t\t\t\t\t\t\tVar V%02u becoming live\n", varNum); | ||
| regNumber intArgReg = compiler->getCallArgIntRegister(segment.GetRegister()); | ||
| inst_Mov(TYP_LONG, intArgReg, segment.GetRegister(), /* canSkip */ false, |
There was a problem hiding this comment.
any reason why we can't skip the move, if possible?
There was a problem hiding this comment.
It will never be possible (this is moving from an XMM register to a GP register)
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
Switch the handling of `GT_JMP` into a single unified implementation that utilizes the new ABI representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the handling of
GT_JMPinto a single unified implementation that utilizes the new ABI representation.Initially I tried doing this through #80732, by implementing support for fast tailcalls on win-x86, but it is non-trivial to guarantee that all
GT_JMPcalls can be translated into fast tail-callableGT_CALLin all scenarios.