Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Release builds should be debuggable as they were in .net7 #102521

Closed
wants to merge 1 commit into from
Closed

[wasm][debugger] Release builds should be debuggable as they were in .net7 #102521

wants to merge 1 commit into from

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented May 21, 2024

Fixes #102307.

@thaystg thaystg requested a review from maraf May 21, 2024 20:14
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@thaystg
Copy link
Member Author

thaystg commented May 21, 2024

@lewing @maraf please let me know if you agree with this fix.
This wasn't working since .NET 8.0.

maraf
maraf requested changes May 22, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix is more complicated #97213. I'm planning to do a backport, but did not finish it yet

@thaystg
Copy link
Member Author

thaystg commented May 22, 2024

@maraf Okay, so can I close this one and you will backport yours?

@maraf
Copy link
Member

maraf commented May 22, 2024

Yes, please

@thaystg
Copy link
Member Author

thaystg commented May 22, 2024

@maraf will fix it.

@thaystg thaystg closed this May 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf requested changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@radical radical Awaiting requested review from radical radical is a code owner

Assignees

@thaystg thaystg

Labels
area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thaystg @maraf