Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-staging] Support building against clang 18 #102529

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

omajid
Copy link
Member

@omajid omajid commented May 21, 2024

This is a targeted backport from a few other PRs that makes it possible to build dotnet/runtme's 6.0 branch on Fedora 40 which includes clang 18.

This is backport of #100258 too.

This is a targeted backport from a few other PRs that makes it possible
to build dotnet/runtme's 6.0 branch on Fedora 40 which includes clang
18.

- dotnet/arcade#14572
- dotnet#94782
- dotnet#99811
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 21, 2024
@omajid omajid changed the title Support building against clang 18 [release/6.0-staging] Support building against clang 18 May 21, 2024
@jkoritzinsky jkoritzinsky added Servicing-consider Issue for next servicing release review source-build Issues relating to dotnet/source-build labels May 21, 2024
@omajid
Copy link
Member Author

omajid commented May 23, 2024

cc @jkotas @jeffschwMSFT

If this PR looks okay, can someone please merge it?

@jeffschwMSFT jeffschwMSFT added this to the 6.0.x milestone May 23, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we can take this as tell mode.

cc @carlossanlop

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 23, 2024
@omajid
Copy link
Member Author

omajid commented Jun 5, 2024

I don't have merge powers. Can someone please merge this for me?

@jkotas jkotas merged commit 2f62289 into dotnet:release/6.0-staging Jun 5, 2024
166 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member Servicing-approved Approved for servicing release source-build Issues relating to dotnet/source-build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants