Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObjectFactory<T> covariant #102553

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make ObjectFactory<T> covariant #102553

wants to merge 2 commits into from

Conversation

alrz
Copy link

@alrz alrz commented May 22, 2024

Closes #101829

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 22, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

@lilinus
Copy link
Contributor

lilinus commented May 22, 2024

I think you need to update src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/ref/Microsoft.Extensions.DependencyInjection.Abstractions.cs too?

@alrz
Copy link
Author

alrz commented May 22, 2024

I think you need to update src/libraries/Microsoft.Extensions.DependencyInjection.Abstractions/ref/Microsoft.Extensions.DependencyInjection.Abstractions.cs too?

Yes, thanks! I did it manually for this change though, is there a tool to regenerate refs?

@huoyaoyuan
Copy link
Member

is there a tool to regenerate refs?

See https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/updating-ref-source.md

@huoyaoyuan
Copy link
Member

The API proposal hasn't been reviewed yet. Since it's so trivial, it's a bit eager to open this PR.

@alrz
Copy link
Author

alrz commented May 22, 2024

The API proposal hasn't been reviewed yet.

Right, I believe this was missed the first time it was introduced, I don't mind this being left open until then though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjectFactory<T> delegate should be covariant
3 participants