Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Use V5 ESRP task with backing MI + AKV #102588

Merged
merged 1 commit into from
May 24, 2024

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented May 23, 2024

main PR: #102542

Description

This PR moves to using WIF + AKV RBAC to support signing diagnostic files without need of manual cert or secret rotation.

Customer Impact

None. Infra change

Regression

None

Testing

Internal test build.

Risk

Low, expansion reqs not changes and same template has signing validation script.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode.

cc @carlossanlop

@hoyosjs hoyosjs added Servicing-approved Approved for servicing release area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 23, 2024
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@hoyosjs hoyosjs merged commit cb188b8 into release/6.0-staging May 24, 2024
82 of 89 checks passed
@hoyosjs
Copy link
Member Author

hoyosjs commented May 24, 2024

This codepath isn't exercised in CI.

@hoyosjs hoyosjs deleted the juhoyosa/patch-sign-v5-6 branch May 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants