[release/8.0-staging] use also SslCertificateTrust when constructing CertificateContext #104541
+50
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tnet#103372) * use also SslCertificateTrust when constructing CertificateContext * 'build * feedback
…ception (dotnet#104016) * Check if certificate collections are not empty before changing trust mode to custom root trust * Enable SslStream_ClientCertificateContext_SendsChain test on Android * Apply suggestions from reviews * Avoid unnecessary allocations
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #103372 and #104016 to release/8.0-staging
Customer Impact
Customers developing Android apps are currently unable to use mutual TLS authentication in certain cases as the
SslStreamCertificateContext.Create(...)method will fail to build an X509Chain instance if the certificate isn't trusted by the OS due to the limitations of the Android platform.Regression
Testing
Unit tests and manual testing on Android emulator.
Risk
Low. The change is mostly limited to Android where this API doesn't currently work in many cases.
/cc @vitek-karas @wfurt