Replace more Unsafe.SizeOf<T> with sizeof(T) #104923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
requested review from
thaystg,
ilonatommy,
marek-safar and
MichalStrehovsky
as code owners
|
Tagging subscribers to this area: @dotnet/area-meta |
stephentoub
force-pushed
the
unsafesizeof
branch
from
51ed51b
to
5f53468
Compare
jkotas
approved these changes
Jul 16, 2024
This was referenced Jul 16, 2024
Also suppress CS8500 globally rather than in hundreds of files individually and fix NoWarns that weren't inheriting global NoWarns.
stephentoub
force-pushed
the
unsafesizeof
branch
from
102b3f9
to
607a30b
Compare
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also suppress CS8500 broadly rather than in hundreds of files individually. We'd previously discussed doing so and decided to wait until we saw the need more broadly, which I believe is now.