Readme for regex implementation #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
…r-expressions.md Co-Authored-By: Stephen Toub <stoub@microsoft.com>
…r-expressions.md Co-Authored-By: Stephen Toub <stoub@microsoft.com>
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
…r-expressions.md Co-Authored-By: Stephen Toub <stoub@microsoft.com>
stephentoub
reviewed
Jan 21, 2020
| * Created by `RegexWriter` | ||
| * Creates `RegexFC`s | ||
| * `FirstChars()` creates `RegexPrefix` from `RegexTree` | ||
| * FC means "First chars": not clear what D means... |
There was a problem hiding this comment.
Let's just rename the type ;)
…r-expressions.md Co-Authored-By: Stephen Toub <stoub@microsoft.com>
…r-expressions.md Co-Authored-By: Stephen Toub <stoub@microsoft.com>
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
…r-expressions.md Co-Authored-By: Stephen Toub <stoub@microsoft.com>
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
…r-expressions.md Co-Authored-By: Stephen Toub <stoub@microsoft.com>
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 21, 2020
src/libraries/System.Text.RegularExpressions/src/dotnet-regular-expressions.md
Outdated
Show resolved
Hide resolved
|
Look OK now? |
stephentoub
approved these changes
Jan 21, 2020
stephentoub
reviewed
Jan 21, 2020
| @@ -0,0 +1,243 @@ | |||
| # Implementation of System.Text.RegularExpressions | |||
There was a problem hiding this comment.
Nit: why did you choose dotnet-regular-expressions.md as the file name rather than, say, README.md?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlines the key types and how they work together. Also some background information, an explanation of extensibility and a start at a high level optimization section.