Allow null IV for Create{Encryptor,Decryptor}. #31634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IV is permitted to be null for most ciphers when in ECB mode.
bartonjs
approved these changes
Feb 2, 2020
stephentoub
approved these changes
Feb 3, 2020
|
Thank you @vcsjones for fixing it |
|
Trying to parse the failures here...
|
Agree, it not seems related to the PR, but I don't think we need issue for failures, it actually might alreaady fixed |
|
/azp run runtime-libraries |
|
No pipelines are associated with this pull request. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like #2389 this time. |
|
Seems unrelated, gonna go ahead and merge this metadata-only change. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IV is permitted to be null for most ciphers when in ECB mode.
The derived types are not yet done, or are in-progress at #2375.
Fixes #31631
@bartonjs @buyaa-n.