Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update ILLinkTasksVersion dependency" #31807

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Conversation

ViktorHofer
Copy link
Member

Reverts #2334

Reverting to unblock official builds which were failing during signing because illink is stripping out assembly attributes from assemblies.

@safern do you know why we don't do signing dry-runs in non-official builds? Those would have captured the break.

Opened #31806 to follow-up on the right fix.

cc @marek-safar

@ViktorHofer ViktorHofer requested a review from a team February 5, 2020 16:22
@ViktorHofer ViktorHofer self-assigned this Feb 5, 2020
@dagood
Copy link
Member

dagood commented Feb 5, 2020

@safern do you know why we don't do signing dry-runs in non-official builds? Those would have captured the break.

Test signing wasn't working without putting some more effort in: #1026

@dagood
Copy link
Member

dagood commented Feb 5, 2020

To link it up--the revert should fix this official build break: #31760.

@ViktorHofer
Copy link
Member Author

Failures are #31809 and the openssl core-eng issue.

@ViktorHofer ViktorHofer merged commit 334391b into master Feb 5, 2020
@ViktorHofer ViktorHofer deleted the revert-2334-illink branch February 5, 2020 18:19
@dagood dagood mentioned this pull request Feb 10, 2020
trylek added a commit to trylek/runtime that referenced this pull request Feb 10, 2020
marek-safar added a commit to marek-safar/runtime that referenced this pull request Feb 12, 2020
ViktorHofer pushed a commit that referenced this pull request Feb 18, 2020
* Revert "Revert "Update ILLinkTasksVersion dependency (#2334)" (#31807)"

This reverts commit 334391b.

* Update ILLink version

* Update ILLink task netcore execution version

* Another version update
@ghost ghost added the will_lock_this label Dec 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants