-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate System.Net.WebProxy for nullable reference types #32612
Conversation
@mmitche looks like this PR is hitting the same NuGet cache bug you hit. Did you file the issue to track that?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
270eed9
to
792483a
Compare
I had not. |
@mmitche eventually figured that out. Ended up filing this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on #31794
Contributes to #2339
(Also fixed a capitalization typo in some internal members.)
cc: @buyaa-n, @eiriktsarpalis, @safern, @eerhardt