Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port CoreCLR's TypeNameBuilder to C#, and use it in Mono too #33701

Merged
merged 7 commits into from
Apr 3, 2020
Merged

Port CoreCLR's TypeNameBuilder to C#, and use it in Mono too #33701

merged 7 commits into from
Apr 3, 2020

Commits on Mar 28, 2020

  1. Port CoreCLR's TypeNameBuilder to C#, and use it in Mono too 

    Mono's System.Reflection.Emit creates type names that fail to be normalized or shaped in all ways that CoreCLR does.

Port CoreCLR's mixed-mode thread-unsafe implementation to thread-safe C#, and start using it in Mono for names in TypeBuilder.

Fixes issues with e.g. null-delimited type names being passed to different Reflection.Emit builders. Contributes to dotnet#2389.
    @alexischr
    alexischr committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    75662e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Update src/libraries/System.Private.CoreLib/src/System/Reflection/Emi… 

    …t/TypeNameBuilder.cs

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
    @alexischr @jkotas
    alexischr and jkotas committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    06fc308 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Private.CoreLib/src/System/Reflection/Emi… 

    …t/TypeNameBuilder.cs

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
    @alexischr @jkotas
    alexischr and jkotas committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    26e8ae1 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Review feedback

    @alexischr
    alexischr committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    d7d5962 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Private.CoreLib/src/System/Reflection/Emi… 

    …t/TypeNameBuilder.cs

Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
    @alexischr @jkotas
    alexischr and jkotas committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    ce0cc8c View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Update src/libraries/System.Private.CoreLib/src/System/Reflection/Emi… 

    …t/TypeNameBuilder.cs

Co-Authored-By: Marek Safar <marek.safar@gmail.com>
    @alexischr @marek-safar
    alexischr and marek-safar committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    b4cf76a View commit details
    Browse the repository at this point in the history

  2. Review feedback

    @alexischr
    alexischr committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    6abeeb4 View commit details
    Browse the repository at this point in the history