Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify instruction set definition #33730

Merged
merged 6 commits into from
Mar 19, 2020
Merged

Unify instruction set definition #33730

merged 6 commits into from
Mar 19, 2020

Commits on Mar 18, 2020

  1. Unify instruction set definition 

    - Build simple DSL to describe the instruction set support of the compiler/jit/etc
- Parse DSL and produce data structures useable throughout our compilation environment
- This is in support of adding more granular instruction set support to crossgen2, but this change is pulled out into its own PR to ease reviewing cost
    @davidwrighton
    davidwrighton committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    6952c06 View commit details
    Browse the repository at this point in the history

  2. Fix formatting and build issues

    @davidwrighton
    davidwrighton committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    4f14632 View commit details
    Browse the repository at this point in the history

  3. Respond to code review feedback

    @davidwrighton
    davidwrighton committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    be186f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Fix diffs between old model and new model 

    - Fix CORJIT_FLAGS::Add, Reset, and IsEmpty
- Make it harder to mess up 64bit instruction set variants by adding helper function to fill them in.
    @davidwrighton
    davidwrighton committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    26a9810 View commit details
    Browse the repository at this point in the history

  2. Improve readability of InstructionSetDesc.txt, and fix vm side X86 bu… 

    …ild issues
    @davidwrighton
    davidwrighton committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    6a65d97 View commit details
    Browse the repository at this point in the history

  3. Add 64 bit variant names to 32bit instruction set enum to remove the … 

    …need to add a large number of #ifdefs to the jit
    @davidwrighton
    davidwrighton committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    c799dc9 View commit details
    Browse the repository at this point in the history